Tony/remove data source (#63)

* Add actions to krew plugin

* Remove -s

* Update test

---------

Co-authored-by: Tony Meehan <[email protected]>

Author: tonymeehan

cmd/plugin/krew/krew.go

@@ -125,7 +125,6 @@ func RootCmd(ctx context.Context, o *krewOptions) *cobra.Command {
 	cmd.Flags().BoolVarP(&cli.Options.Disabled, "disabled", "d", false, ux.HelpDisabled)
 	cmd.Flags().BoolVarP(&cli.Options.Cron, "cron", "j", false, ux.HelpCron)
 	cmd.Flags().BoolVarP(&cli.Options.Generate, "generate", "g", false, ux.HelpGenerate)
-	cmd.Flags().StringVarP(&cli.Options.Source, "source", "s", "", ux.HelpSource)
 	cmd.Flags().StringVarP(&cli.Options.Level, "level", "l", "", ux.HelpLevel)
 	cmd.Flags().StringVarP(&cli.Options.Name, "name", "o", "", ux.HelpName)
 	cmd.Flags().BoolVarP(&cli.Options.Quiet, "quiet", "q", false, ux.HelpQuiet)

test/cli_parity_test.go

@@ -1,16 +1,16 @@
 package test
 
 import (
-        "context"
-        "reflect"
-        "strings"
-        "testing"
-
-        krewpkg "github.com/prequel-dev/preq/cmd/plugin/krew"
-        "github.com/prequel-dev/preq/internal/pkg/cli"
-        "github.com/google/go-cmp/cmp"
-        "github.com/spf13/pflag"
-        "k8s.io/cli-runtime/pkg/genericclioptions"
+	"context"
+	"reflect"
+	"strings"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+	krewpkg "github.com/prequel-dev/preq/cmd/plugin/krew"
+	"github.com/prequel-dev/preq/internal/pkg/cli"
+	"github.com/spf13/pflag"
+	"k8s.io/cli-runtime/pkg/genericclioptions"
 )
 
 func flagNameFromField(name string) string {
@@ -48,12 +48,18 @@ func krewFlagSet() map[string]struct{} {
 }
 
 func TestKrewAndCLIMatch(t *testing.T) {
-        cliFlags := cliFlagSet()
-        krewFlags := krewFlagSet()
+	cliFlags := cliFlagSet()
+	krewFlags := krewFlagSet()
+
+	// Remove source flag from CLI flags if it's missing in krew
+	// This allows krew to be missing the source flag without failing the test
+	if _, exists := krewFlags["source"]; !exists {
+		delete(cliFlags, "source")
+	}
 
-        if diff := cmp.Diff(cliFlags, krewFlags); diff != "" {
-                t.Fatalf("flags mismatch (-cli +krew):\n%s", diff)
-        }
+	if diff := cmp.Diff(cliFlags, krewFlags); diff != "" {
+		t.Fatalf("flags mismatch (-cli +krew):\n%s", diff)
+	}
 }
 
 func TestCoverageOutput(t *testing.T) {