Skip to content

Commit c3cdaae

Browse files
duxiao1212facebook-github-bot
authored andcommitted
fix: Added spillBaseDir for PartitionAndSerializeReplayer
Summary: Added spillBaseDir for PartitionAndSerializeReplayer ``` == NO RELEASE NOTE == ``` Differential Revision: D86552256
1 parent 9ec75df commit c3cdaae

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

presto-native-execution/presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@
1111
* See the License for the specific language governing permissions and
1212
* limitations under the License.
1313
*/
14-
/*
15-
* Copyright (c) Facebook, Inc. and its affiliates.
16-
*/
1714
#include "presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.h"
18-
1915
#include "presto_cpp/main/operators/PartitionAndSerialize.h"
2016
#include "velox/tool/trace/TraceReplayTaskRunner.h"
2117

@@ -32,6 +28,7 @@ PartitionAndSerializeReplayer::PartitionAndSerializeReplayer(
3228
const std::string& taskId,
3329
const std::string& nodeId,
3430
const std::string& nodeName,
31+
const std::string& spillBaseDir,
3532
const std::string& driverIds,
3633
uint64_t queryCapacity,
3734
folly::Executor* executor)
@@ -41,6 +38,7 @@ PartitionAndSerializeReplayer::PartitionAndSerializeReplayer(
4138
taskId,
4239
nodeId,
4340
nodeName,
41+
spillBaseDir,
4442
driverIds,
4543
queryCapacity,
4644
executor) {}

presto-native-execution/presto_cpp/main/tool/trace/PartitionAndSerializeReplayer.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,12 @@
1111
* See the License for the specific language governing permissions and
1212
* limitations under the License.
1313
*/
14-
/*
15-
* Copyright (c) Facebook, Inc. and its affiliates.
16-
*/
1714
#pragma once
1815

1916
#include "velox/core/PlanNode.h"
2017
#include "velox/tool/trace/OperatorReplayerBase.h"
2118

2219
namespace facebook::velox::tool::trace {
23-
2420
/// The replayer to replay the traced 'PartitionAndSerialize' operators.
2521
class PartitionAndSerializeReplayer final : public OperatorReplayerBase {
2622
public:
@@ -30,6 +26,7 @@ class PartitionAndSerializeReplayer final : public OperatorReplayerBase {
3026
const std::string& taskId,
3127
const std::string& nodeId,
3228
const std::string& nodeName,
29+
const std::string& spillBaseDir,
3330
const std::string& driverIds,
3431
uint64_t queryCapacity,
3532
folly::Executor* executor);

presto-native-execution/presto_cpp/main/tool/trace/TraceReplayerMain.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ class PrestoTraceReplayRunner
5656
FLAGS_task_id,
5757
FLAGS_node_id,
5858
nodeName,
59+
"",
5960
FLAGS_driver_ids,
6061
queryCapacityBytes,
6162
cpuExecutor_.get());

presto-native-execution/presto_cpp/main/tool/trace/tests/PartitionAndSerializeReplayerTest.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ TEST_F(PartitionAndSerializeReplayerTest, basicReplay) {
202202
task->taskId(),
203203
partitionNodeId,
204204
"PartitionAndSerialize",
205+
"",
205206
driverIds,
206207
queryCapacity,
207208
executor_.get());

0 commit comments

Comments
 (0)