fix(eslint): if no fix is necessary, do not return undefined

Author: Kent C. Dodds

src/index.js

@@ -38,8 +38,11 @@ function format({
   options.disableLog = disableLog
 
   try {
+    // console.log('text', text)
     const pretty = prettify(text, prettierOptions, prettierPath)
+    // console.log('pretty', pretty)
     const eslintFixed = eslintFix(pretty, eslintConfig, eslintPath)
+    // console.log('eslintFixed', eslintFixed)
     return eslintFixed
   } finally {
     options.disableLog = originalLogValue
@@ -81,7 +84,9 @@ function eslintFix(text, eslintConfig, eslintPath) {
   const eslint = getESLintCLIEngine(eslintPath, eslintOptions)
   try {
     const report = eslint.executeOnText(text)
-    const [{output}] = report.results
+    // default the output to text because if there's nothing
+    // to fix, eslint doesn't provide `output`
+    const [{output = text}] = report.results
     // NOTE: We're ignoring linting errors/warnings here and
     // defaulting to the given text if there are any
     // because all we're trying to do is fix what we can.

src/index.test.js

@@ -49,6 +49,14 @@ const tests = [
     },
     output: defaultOutput(),
   },
+  {
+    title: 'with code that needs no fixing',
+    input: {
+      text: 'var [foo, {bar}] = window.APP;',
+      eslintConfig: {rules: {}},
+    },
+    output: 'var [foo, {bar}] = window.APP;',
+  },
   // if you have a bug report or something,
   // go ahead and add a test case here
 ]