Skip to content

Extend doesn't incorporate extension into model update #1

@femtomc

Description

@femtomc

In these lines:

https://github.com/probcomp/GenProx.jl/blob/6083d1cda2f2a0db4d8497c3430b9c9d25316f54/src/inference/composable_smc.jl#L221-L227

shouldn't the extension be merged into algorithm.new_constraints before the update call? (E.g. because extension is from the latent proposal ProxDistribution -- and update without extension will just sample from the model prior for the transition)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions