Skip to content

Commit f1d5a00

Browse files
committed
Resolve some todos (ariel, semihosting)
1 parent 6d9faec commit f1d5a00

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/export.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,15 @@ pub fn check_outcome<T: TestOutcome>(outcome: T) -> ! {
2525
}
2626

2727
/*
28-
// TODO: make stack size configurable
29-
#[ariel_os::thread(autostart, stacksize = 16384)]
30-
fn embedded_test_thread() {
31-
unsafe { __embedded_test_entry() }
32-
}
33-
*/
28+
// TODO: Readd support for ariel os startup. Ariel OS is currently not published to crates.io
29+
#[cfg(feature = "ariel-os")]
30+
#[ariel_os::thread(autostart, stacksize = 16384)]
31+
fn embedded_test_thread() {
32+
// TODO: make stack size configurable
33+
unsafe { __embedded_test_entry() }
34+
}*/
3435

35-
#[export_name = "main"]
36+
#[cfg_attr(not(feature = "ariel-os"), export_name = "main")]
3637
pub unsafe extern "C" fn __embedded_test_entry() -> ! {
3738
ensure_linker_file_was_added_to_rustflags();
3839
}

src/semihosting.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ pub fn exit(code: i32) -> ! {
1414
}
1515

1616
pub fn run_test(_test: &str) -> ! {
17-
// TODO: print reason
17+
error!("Running test by name is no longer supported by embedded-test. Please upgrade probe-rs to the latest version");
1818
abort();
1919
}
2020

2121
pub fn print_test_list() -> ! {
22-
// TODO: print reason: We no longer print the tests via semihosting, they should be read from the ELF with probe-rs
22+
error!("Querying tests via semihosting is no longer supported by embedded-test. Please upgrade probe-rs to the latest version");
2323
abort();
2424
}

0 commit comments

Comments
 (0)