-
-
Notifications
You must be signed in to change notification settings - Fork 175
Open
Labels
Description
Subject of the issue
Support for laravel 8:
- Validation rules in RuleListTrait should match laravel 8.x validation rules
Your environment
- version of this package: newest
- version of Laravel: 8.x or higher
Steps to reproduce
Use any of the none pre-defined available validation rules; EG: "Present". It will consider these rules as "server rules" and make them laravelValidationRemote properties. which causes unnecessary requests for issues that do not require server-side validation.
List of rules that are not added in Support/RuleListTrait.php
- AcceptedIf
- CurrentPassword (should most likely be serverRule)
- DateEquals
- EndsWith
- Exclude
- ExcludeIf
- ExcludeUnless
- GreaterThan
- GreaterThanOrEqual
- LessThan
- LessThanOrEqual
- MultipleOf
- NotRegex
- Present
- Prohibited
- ProhibitedIf
- ProhibitedUnless
- Prohibits
- StartsWith
- UUID
Expected behaviour
Validation rules are properly parsed as clientRules or serverRules when they're laravel default rules that don't require server side logic.
Actual behaviour
All laravel validation rules that are newly added in laravel 8.x will be parsed as serverRules and create overhead in Ajax requests.