refactor: rename env var to PSALM_LARAVEL_PLUGIN_CACHE_PATH for better clarity

Author: Viacheslav Danilin

src/Providers/CacheDirectoryProvider.php

@@ -7,15 +7,17 @@
 use function getenv;
 use function rtrim;
 
+use const DIRECTORY_SEPARATOR;
+
 final class CacheDirectoryProvider
 {
     public static function getCacheLocation(): string
     {
-        $env = getenv('LARAVEL_PLUGIN_CACHE_PATH');
+        $env = getenv('PSALM_LARAVEL_PLUGIN_CACHE_PATH');
         if ($env !== false && $env !== '') {
-            return rtrim($env, '/');
+            return rtrim($env, DIRECTORY_SEPARATOR);
         }
 
-        return __DIR__ . '/../../cache';
+        return __DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'cache';
     }
 }

tests/Unit/Providers/CacheDirectoryProviderTest.php

@@ -10,25 +10,27 @@
 use function putenv;
 use function sys_get_temp_dir;
 
+use const DIRECTORY_SEPARATOR;
+
 final class CacheDirectoryProviderTest extends TestCase
 {
     protected function tearDown(): void
     {
-        putenv('LARAVEL_PLUGIN_CACHE_PATH');
+        putenv('PSALM_LARAVEL_PLUGIN_CACHE_PATH');
     }
 
     public function testReturnsDefaultPathIfEnvNotSet(): void
     {
         $path = CacheDirectoryProvider::getCacheLocation();
 
-        $this->assertStringEndsWith('/cache', $path);
+        $this->assertStringEndsWith(DIRECTORY_SEPARATOR . 'cache', $path);
         $this->assertFileExists($path);
     }
 
     public function testReturnsCustomPathFromEnv(): void
     {
         $custom = sys_get_temp_dir() . '/psalm-laravel-stubs-test';
-        putenv("LARAVEL_PLUGIN_CACHE_PATH={$custom}");
+        putenv("PSALM_LARAVEL_PLUGIN_CACHE_PATH={$custom}");
 
         $this->assertSame($custom, CacheDirectoryProvider::getCacheLocation());
     }