Skip to content

Commit 5f713f4

Browse files
authored
ci: address security findings (#389)
* ci: address security findings Signed-off-by: William Woodruff <[email protected]> * ci: use runner's stable Rust toolchain Or, where nightly is required, bootstrap it through rustup directly. Signed-off-by: William Woodruff <[email protected]> --------- Signed-off-by: William Woodruff <[email protected]>
1 parent 8e66fc0 commit 5f713f4

File tree

4 files changed

+39
-14
lines changed

4 files changed

+39
-14
lines changed

.github/workflows/benchmarks.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,17 @@ on:
77
pull_request:
88
workflow_dispatch:
99

10+
permissions: {}
11+
1012
jobs:
1113
benchmarks:
1214
name: Run benchmarks
1315
runs-on: ubuntu-latest
1416
steps:
1517
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
18+
with:
19+
persist-credentials: false
20+
1621
- name: Setup rust toolchain, cache and cargo-codspeed binary
1722
uses: moonrepo/setup-rust@ede6de059f8046a5e236c94046823e2af11ca670 # v1
1823
with:

.github/workflows/cargo_publish_dry_run.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,22 @@
33
name: Check crate publishing works
44
on:
55
pull_request:
6-
branches: [ release ]
6+
branches: [release]
77
workflow_dispatch:
88

99
env:
1010
CARGO_TERM_COLOR: always
1111

12+
permissions: {}
13+
1214
jobs:
1315
cargo_publish_dry_run:
1416
name: Publishing works
1517
runs-on: ubuntu-latest
1618
steps:
1719
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
18-
- name: Install stable Rust
19-
uses: dtolnay/rust-toolchain@stable
20+
with:
21+
persist-credentials: false
2022

2123
- name: Get Cargo version
2224
id: cargo_version

.github/workflows/ci.yml

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ on:
33
pull_request:
44
merge_group:
55
push:
6-
branches: [ release, dev ]
7-
schedule: [ cron: "0 6 * * 4" ]
6+
branches: [release, dev]
7+
schedule: [cron: "0 6 * * 4"]
8+
9+
permissions: {}
810

911
env:
1012
CARGO_TERM_COLOR: always
@@ -15,18 +17,21 @@ jobs:
1517
runs-on: ubuntu-latest
1618
steps:
1719
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
18-
- uses: dtolnay/rust-toolchain@stable
20+
with:
21+
persist-credentials: false
22+
1923
- run: cargo build --workspace
24+
2025
- run: cargo test --all-features --workspace
2126

2227
clippy:
2328
name: Clippy
2429
runs-on: ubuntu-latest
2530
steps:
2631
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
27-
- uses: dtolnay/rust-toolchain@stable
2832
with:
29-
components: clippy
33+
persist-credentials: false
34+
3035
- name: Check Clippy lints
3136
env:
3237
RUSTFLAGS: -D warnings
@@ -37,17 +42,19 @@ jobs:
3742
runs-on: ubuntu-latest
3843
steps:
3944
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
40-
- uses: dtolnay/rust-toolchain@stable
4145
with:
42-
components: rustfmt
46+
persist-credentials: false
47+
4348
- run: cargo fmt --all -- --check
4449

4550
check_documentation:
4651
name: Docs
4752
runs-on: ubuntu-latest
4853
steps:
4954
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
50-
- uses: dtolnay/rust-toolchain@stable
55+
with:
56+
persist-credentials: false
57+
5158
- name: Check documentation
5259
env:
5360
RUSTDOCFLAGS: -D warnings
@@ -58,7 +65,13 @@ jobs:
5865
runs-on: ubuntu-latest
5966
steps:
6067
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
61-
- uses: dtolnay/rust-toolchain@nightly
68+
with:
69+
persist-credentials: false
70+
71+
- run: rustup toolchain install nightly
72+
6273
- run: cargo +nightly update -Zminimal-versions
74+
6375
- run: cargo +nightly build --workspace
76+
6477
- run: cargo +nightly test --all-features --workspace

.github/workflows/deploy_documentation.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,23 @@
33
name: Deploy documentation
44
on:
55
push:
6-
branches: [ dev ]
6+
branches: [dev]
77
workflow_dispatch:
88

9+
permissions: {}
10+
911
env:
1012
CARGO_TERM_COLOR: always
1113

1214
jobs:
1315
deploy_documentation:
1416
runs-on: ubuntu-latest
17+
permissions:
18+
contents: write # for peaceiris/actions-gh-pages
1519
steps:
1620
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
17-
- uses: dtolnay/rust-toolchain@stable
21+
with:
22+
persist-credentials: false
1823

1924
- name: Build documentation
2025
run: cargo doc --no-deps

0 commit comments

Comments
 (0)