Merge pull request #47 from pubnub/develop

Add Listener fix for Signal

Author: crimsonred

.pubnub.yml

@@ -1,18 +1,25 @@
 --- 
 changelog:
+  - 
+    changes: 
+      - 
+        text: "Correct null check for signal callback"
+        type: bug
+    date: Mar 10, 20  
+    version: v4.8.1
   - 
     changes: 
       - 
         text: "Token Management System - Client end"
         type: improvement
-    date: Feb 18, 19  
+    date: Feb 18, 20  
     version: v4.8.0
   - 
     changes: 
       - 
         text: "HereNow Deserialization Error fix"
         type: improvement
-    date: Feb 5, 19  
+    date: Feb 5, 20  
     version: v4.7.3
   - 
     changes: 
@@ -22,14 +29,14 @@ changelog:
       - 
         text: "Presence Heartbeat defaults to 300"
         type: improvement
-    date: Jan 16, 19  
+    date: Jan 16, 20  
     version: v4.7.2
   - 
     changes: 
       - 
         text: "Objects Filtering"
         type: improvement
-    date: Jan 6, 19  
+    date: Jan 6, 20  
     version: v4.7.1   
   - 
     changes: 

PubNubUnity/Assets/PubNub/Editor/SignalTest.cs

@@ -22,6 +22,23 @@ public void TestSignalRequestQueryParam ()
             TestSignalCommon (true, true);
         }
 
+        [Test]
+        public void TestAddListenerSignalCallback ()
+        {
+            PNConfiguration pnConfiguration = new PNConfiguration ();
+            PubNubUnity pnUnity = new PubNubUnity(pnConfiguration, null, null);
+            bool receivedCallback = false;
+            Action<PNSignalEventResult> callback = (pnser) => receivedCallback = true;
+            pnUnity.AddListener(null, null, null, callback, null, null, null, null);
+
+            pnUnity.RaiseEvent(new SubscribeEventEventArgs()
+            {
+                SignalEventResult = new PNSignalEventResult(null, null, null, 0, 0, null, null)
+            });
+
+            Assert.IsTrue(receivedCallback);
+        }
+
         public void TestSignalCommon(bool ssl, bool sendQueryParams){
             string channel = EditorCommon.GetRandomChannelName();
             string message = "Test signal";

PubNubUnity/Assets/PubNub/PubNubUnity/PubNubUnity.cs

@@ -70,28 +70,28 @@ public void AddListener(Action<PNStatus> statusCallback, Action<PNMessageResult>
                 #endif
 
                 if(mea!=null){
-                    if(mea.Status != null){
+                    if(mea.Status != null && statusCallback != null){
                         statusCallback(mea.Status);
                     }
-                    if(mea.MessageResult != null){
+                    if(mea.MessageResult != null && messageCallback != null){
                         messageCallback(mea.MessageResult);
                     }
-                    if(mea.PresenceEventResult != null){
+                    if(mea.PresenceEventResult != null && presenceCallback != null){
                         presenceCallback(mea.PresenceEventResult);
                     }
-                    if(mea.MessageResult != null){
+                    if(mea.SignalEventResult != null && signalCallback != null){
                         signalCallback(mea.SignalEventResult);
                     }
-                    if(mea.UserEventResult != null){
+                    if(mea.UserEventResult != null && userCallback != null){
                         userCallback(mea.UserEventResult);
                     }
-                    if(mea.SpaceEventResult != null){
+                    if(mea.SpaceEventResult != null && spaceCallback != null){
                         spaceCallback(mea.SpaceEventResult);
                     }
-                    if(mea.MembershipEventResult != null){
+                    if(mea.MembershipEventResult != null && membershipCallback != null){
                         membershipCallback(mea.MembershipEventResult);
                     }
-                    if(mea.MessageActionsEventResult != null){
+                    if(mea.MessageActionsEventResult != null && messageActionsCallback != null){
                         messageActionsCallback(mea.MessageActionsEventResult);
                     }
 

PubNubUnity/Assets/PubNub/PubNubUnity/PubNubUnityBase.cs

@@ -7,7 +7,7 @@ namespace PubNubAPI
     public class PubNubUnityBase
     {
         protected Counter publishMessageCounter;
-        private const string build = "4.8.0";
+        private const string build = "4.8.1";
         private string pnsdkVersion = string.Format ("PubNub-CSharp-Unity/{0}", build);
 
         public string Version {

README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://api.travis-ci.org/pubnub/unity.svg?branch=master)](https://travis-ci.org/pubnub/unity) [![Build status](https://ci.appveyor.com/api/projects/status/1p3494pnt6rgqdsm/branch/master?svg=true)](https://ci.appveyor.com/project/PubNub/unity)
 
-## PubNub 4.8.0 Web Data Push Cloud-Hosted API for Unity 5+
+## PubNub 4.8.1 Web Data Push Cloud-Hosted API for Unity 5+
 ### Supports PC, Mac, Linux, iOS, Android, Windows Store Universal 10 and WebGL
 
 ## All new PubNub Unity SDK

VERSION

@@ -1 +1 @@
-4.8.0
+4.8.1