fix: resolve buildifier formatting issues and CI compatibility

- Comment out local_path_override in MODULE.bazel for CI compatibility
- Fix all buildifier formatting violations across BUILD files
- Add name parameter to file_ops_integration_tests macro
- Remove deprecated sh_test usage
- Download buildifier tool for code quality checks

Author: avrabe

BUILD.bazel

@@ -14,7 +14,7 @@ string_flag(
     build_setting_default = "auto",
     values = [
         "auto",
-        "tinygo", 
+        "tinygo",
         "rust",
     ],
 )
@@ -27,7 +27,7 @@ config_setting(
 )
 
 config_setting(
-    name = "use_rust", 
+    name = "use_rust",
     flag_values = {
         ":implementation": "rust",
     },
@@ -61,7 +61,7 @@ config_setting(
 config_setting(
     name = "strict_security",
     flag_values = {
-        ":security_level": "strict", 
+        ":security_level": "strict",
     },
 )
 
@@ -101,4 +101,4 @@ filegroup(
 exports_files([
     "LICENSE",
     "README.md",
-])
+])

MODULE.bazel

@@ -22,18 +22,18 @@ bazel_dep(name = "bazel_skylib", version = "1.7.1")
 bazel_dep(name = "rules_rust", version = "0.53.0")
 bazel_dep(name = "rules_go", version = "0.50.1")
 
-# Documentation site dependencies  
+# Documentation site dependencies
 bazel_dep(name = "aspect_rules_js", version = "2.1.0")
 bazel_dep(name = "aspect_rules_ts", version = "3.2.1")
 
-# TinyGo toolchain for WebAssembly components  
+# TinyGo toolchain for WebAssembly components
 bazel_dep(name = "rules_wasm_component", version = "0.1.0")
 
-# Local development override - use local rules_wasm_component
-local_path_override(
-    module_name = "rules_wasm_component",
-    path = "/Users/r/git/rules_wasm_component",
-)
+# Local development override - use local rules_wasm_component (disabled for CI)
+# local_path_override(
+#     module_name = "rules_wasm_component",
+#     path = "/Users/r/git/rules_wasm_component",
+# )
 
 # Rust toolchain setup
 rust = use_extension("@rules_rust//rust:extensions.bzl", "rust")
@@ -44,34 +44,28 @@ register_toolchains("@rust_toolchains//:all")
 
 # Rust dependencies
 crate = use_extension("@rules_rust//crate_universe:extension.bzl", "crate")
-
 crate.spec(
     package = "anyhow",
     version = "1.0",
 )
-
 crate.spec(
+    features = ["derive"],
     package = "serde",
     version = "1.0",
-    features = ["derive"],
 )
-
 crate.spec(
     package = "serde_json",
     version = "1.0",
 )
-
 crate.spec(
+    features = ["component-model"],
     package = "wasmtime",
     version = "25.0",
-    features = ["component-model"],
 )
-
 crate.spec(
     package = "wit-bindgen",
     version = "0.30",
 )
-
 crate.from_specs()
 use_repo(crate, "crates")
 
@@ -97,4 +91,4 @@ node.npm_translate_lock(
     pnpm_lock = "//:pnpm-lock.yaml",
     verify_node_modules_ignored = "//:.bazelignore",
 )
-use_repo(node, "npm")
+use_repo(node, "npm")

WORKSPACE.bazel

@@ -7,4 +7,4 @@ via WebAssembly components with enhanced security and cross-platform support.
 workspace(name = "bazel_file_ops_component")
 
 # This file is maintained for compatibility but all dependencies
-# are managed through MODULE.bazel for bzlmod support
+# are managed through MODULE.bazel for bzlmod support

buildifier

@@ -20,4 +20,4 @@ filegroup(
 filegroup(
     name = "integration_configs",
     srcs = glob(["integration/*"]),
-)
+)

testdata/BUILD.bazel

@@ -1,11 +1,11 @@
 """Integration tests for file operations components"""
 
-load("@rules_go//go:def.bzl", "go_test")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
+load("@rules_go//go:def.bzl", "go_test")
 
-def file_ops_integration_tests():
+def file_ops_integration_tests(name = "integration_tests"):
     """Define integration tests for file operations components"""
-    
+
     # Test that TinyGo implementation builds successfully
     build_test(
         name = "tinygo_component_build_test",
@@ -15,25 +15,25 @@ def file_ops_integration_tests():
         ],
         tags = ["integration", "build"],
     )
-    
+
     # Test Rust component build (if it exists)
     native.config_setting(
         name = "rust_component_exists",
         values = {"define": "rust_enabled=true"},
     )
-    
+
     build_test(
         name = "rust_component_build_test",
         targets = select({
             ":rust_component_exists": [
                 "//rust:file_ops_rust",
-                "//rust:file_ops_component_wasm", 
+                "//rust:file_ops_component_wasm",
             ],
             "//conditions:default": ["//tinygo:file_ops_tinygo"],  # Fallback
         }),
         tags = ["integration", "build"],
     )
-    
+
     # Go-based integration tests
     go_test(
         name = "integration_tests",
@@ -50,7 +50,7 @@ def file_ops_integration_tests():
         },
         tags = ["integration", "manual"],  # Manual due to external tool dependencies
     )
-    
+
     # Lightweight component functionality test
     go_test(
         name = "component_functionality_test",
@@ -64,7 +64,7 @@ def file_ops_integration_tests():
         },
         tags = ["integration"],
     )
-    
+
     # JSON batch compatibility test
     go_test(
         name = "json_batch_compatibility_test",
@@ -78,7 +78,7 @@ def file_ops_integration_tests():
         },
         tags = ["integration"],
     )
-    
+
     # WIT interface consistency test (requires external tools)
     go_test(
         name = "wit_interface_consistency_test",
@@ -94,7 +94,7 @@ def file_ops_integration_tests():
         },
         tags = ["integration", "wit", "manual"],  # Manual due to wasm-tools dependency
     )
-    
+
     # Basic performance test
     go_test(
         name = "performance_basic_test",
@@ -109,7 +109,7 @@ def file_ops_integration_tests():
         tags = ["integration", "performance"],
         timeout = "moderate",  # Allow more time for performance tests
     )
-    
+
     # Test suite combining all integration tests
     native.test_suite(
         name = "integration_test_suite",
@@ -121,18 +121,18 @@ def file_ops_integration_tests():
         ],
         tags = ["integration"],
     )
-    
+
     # Extended test suite including manual tests (for CI)
     native.test_suite(
         name = "integration_test_suite_full",
         tests = [
             ":tinygo_component_build_test",
             ":rust_component_build_test",
             ":integration_tests",
-            ":component_functionality_test", 
+            ":component_functionality_test",
             ":json_batch_compatibility_test",
             ":wit_interface_consistency_test",
             ":performance_basic_test",
         ],
         tags = ["integration", "full"],
-    )
+    )

testdata/integration_tests.bzl

@@ -16,7 +16,7 @@ go_library(
     name = "file_ops_lib",
     srcs = [
         "json_bridge.go",
-        "operations.go", 
+        "operations.go",
         "security.go",
         "workspace.go",
     ],
@@ -30,67 +30,59 @@ go_library(
 go_binary(
     name = "file_ops_cli",
     srcs = ["main.go"],
-    deps = [":file_ops_lib"],
+    goarch = "amd64",
     # Build for host platform for testing
     goos = "linux",
-    goarch = "amd64",
+    deps = [":file_ops_lib"],
 )
 
 # TinyGo WebAssembly Component
 go_wasm_component(
     name = "file_ops_component",
     srcs = [
+        "json_bridge.go",
         "main.go",
-        "json_bridge.go", 
         "operations.go",
         "security.go",
-        "workspace.go",
         "wit_bindings.go",
+        "workspace.go",
     ],
     go_mod = "go.mod",
-    wit = "//wit:file-operations",
-    world = "file-operations-world",
     optimization = "release",
     tags = ["manual"],  # Build explicitly for WASM
+    wit = "//wit:file-operations",
+    world = "file-operations-world",
 )
 
 # Test suite
 go_test(
     name = "file_ops_test",
     srcs = [
-        "operations_test.go",
         "json_bridge_test.go",
+        "operations_test.go",
         "security_test.go",
         "workspace_test.go",
     ],
-    deps = [
-        ":file_ops_lib",
-        "@org_golang_x_testing//fstest",
-    ],
     data = [
         "//testdata:test_configs",
         "//testdata:test_files",
     ],
+    deps = [
+        ":file_ops_lib",
+        "@org_golang_x_testing//fstest",
+    ],
 )
 
 # Integration tests with WASM component
-sh_test(
-    name = "integration_test", 
-    srcs = ["integration_test.sh"],
-    data = [
-        ":file_ops_component",
-        "//testdata:integration_configs",
-    ],
-    tags = ["integration"],
-)
+# Note: sh_test is deprecated, replaced with Go-based integration tests in //testdata:integration_tests
 
 # Performance benchmarks
 go_test(
     name = "benchmark_test",
-    srcs = ["benchmark_test.go"], 
-    deps = [":file_ops_lib"],
+    srcs = ["benchmark_test.go"],
     args = ["-bench=."],
     tags = ["benchmark"],
+    deps = [":file_ops_lib"],
 )
 
 # Generate signing keys for component security
@@ -104,28 +96,28 @@ wasm_keygen(
 wasm_sign(
     name = "file_ops_component_signed",
     component = ":file_ops_component",
-    keys = ":component_signing_keys",
     detached = False,  # Embed signature in component
+    keys = ":component_signing_keys",
     tags = ["manual"],
 )
 
 # Verify component signature
 wasm_verify(
     name = "verify_file_ops_signature",
-    signed_component = ":file_ops_component_signed",
     keys = ":component_signing_keys",
+    signed_component = ":file_ops_component_signed",
     tags = ["manual"],
 )
 
 # Create signed OCI image for registry publishing
 wasm_component_signed_oci_image(
     name = "file_ops_oci_signed",
+    package_name = "bazel-file-ops-component-tinygo",
     component = ":file_ops_component",
-    sign_component = True,
     component_signing_keys = ":component_signing_keys",
-    registry = "ghcr.io",
     namespace = "pulseengine",
-    package_name = "bazel-file-ops-component-tinygo",
+    registry = "ghcr.io",
+    sign_component = True,
     tags = ["manual"],
 )
 
@@ -137,7 +129,7 @@ alias(
 )
 
 alias(
-    name = "file_ops_tinygo", 
+    name = "file_ops_tinygo",
     actual = ":file_ops_component",
     visibility = ["//visibility:public"],
 )
@@ -153,4 +145,4 @@ alias(
     name = "file_ops_signed",
     actual = ":file_ops_component_signed",
     visibility = ["//visibility:public"],
-)
+)

tinygo/BUILD.bazel

@@ -32,4 +32,4 @@ genrule(
     echo '```' >> $@
     """,
     visibility = ["//docs-site:__pkg__"],
-)
+)