(CAT-2207) Remove legacy facts

Author: amitkarsale

Gemfile

@@ -36,9 +36,11 @@ group :development do
   gem "rb-readline", '= 0.5.5',                  require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "github_changelog_generator", '= 1.15.2',  require: false
   gem "octokit", '= 4.21.0',                     require: false
+  gem "puppet_litmus", '~> 1.0',                 require: false, platforms: [:ruby, :x64_mingw]
+  gem "serverspec", '~> 2.41',                   require: false
 end
 group :system_tests do
-  gem "puppet_litmus", '~> 1.0', require: false, platforms: [:ruby, :x64_mingw]
+  # gem "puppet_litmus", '~> 1.0', require: false, platforms: [:ruby, :x64_mingw]
   gem "serverspec", '~> 2.41',   require: false
 end
 

tasks/st0361_uploading_facts.rb

@@ -4,7 +4,7 @@
 require 'json'
 require 'open3'
 
-path = if Facter.value(:osfamily).eql? 'windows'
+path = if Facter.value(:'os.family').eql? 'windows'
          'C:\\"Program Files"\\"Puppet Labs"\\Puppet\\bin\\'
        else
          '/opt/puppetlabs/bin/'