Merge branch 'main' into add-ann

Author: tlambert03

.github/workflows/ci.yml

@@ -58,6 +58,8 @@ jobs:
 
       - name: 🧪 Run Tests
         run: uv run coverage run -p -m pytest -v
+        env:
+          PYTEST_ADDOPTS: ${{ matrix.resolution == 'lowest-direct' && '-W ignore' || '' }}
 
       - name: Upload coverage
         uses: actions/upload-artifact@v4
@@ -82,6 +84,8 @@ jobs:
         exclude:
           - platform: "macos-latest"
             extra: "pyside2"
+          - python-version: "3.12"
+            extra: "pyside2"
 
     steps:
       - uses: actions/checkout@v4
@@ -94,7 +98,7 @@ jobs:
           python-version: ${{ matrix.python-version }}
           enable-cache: true
           cache-dependency-glob: "**/pyproject.toml"
-      
+
       - uses: pyvista/setup-headless-display-action@v4
         with:
           qt: true
@@ -104,6 +108,8 @@ jobs:
 
       - name: 🧪 Run Tests
         run: uv run coverage run -p -m pytest -v
+        env:
+          PYTEST_ADDOPTS: ${{ matrix.resolution == 'lowest-direct' && '-W ignore' || '' }}
 
       # If something goes wrong with --pre tests, we can open an issue in the repo
       - name: 📝 Report --pre Failures
@@ -175,4 +181,4 @@ jobs:
       - uses: softprops/action-gh-release@v2
         with:
           generate_release_notes: true
-          files: './dist/*'
+          files: "./dist/*"

.gitignore

@@ -107,4 +107,4 @@ ENV/
 app_model/_version.py
 src/app_model/_version.py
 
-uv.lock
+uv.lock

pyproject.toml

@@ -37,7 +37,7 @@ classifiers = [
 ]
 dynamic = ["version"]
 dependencies = [
-    "psygnal>=0.3.4",
+    "psygnal>=0.10",
     "pydantic>=1.10.18",
     "pydantic-compat>=0.1.1",
     "in-n-out>=0.1.5",
@@ -57,8 +57,8 @@ pyqt5 = [
     "pyqt5-qt5>=5.15.4; sys_platform != 'win32'",
 ]
 pyqt6 = ["app-model[qt]", "PyQt6>=6.4.0"]
-pyside2 = ["app-model[qt]", "PySide2>=5.15.2"]
-pyside6 = ["app-model[qt]", "PySide6>=6.4.0"]
+pyside2 = ["app-model[qt]", "PySide2>=5.15.2.1"]
+pyside6 = ["app-model[qt]", "PySide6>=6.6.0"]
 
 # https://peps.python.org/pep-0735/
 # setup with `uv sync` or `pip install -e . --group dev`
@@ -152,7 +152,6 @@ filterwarnings = [
     "error",
     "ignore:Enum value:DeprecationWarning:superqt",
     "ignore:Failed to disconnect::pytestqt",
-    "ignore:ast.Str is deprecated:DeprecationWarning",
     "ignore:Failing to pass a value to the 'type_params' parameter::pydantic",
     "ignore:`__get_validators__` is deprecated and will be removed",
 ]
@@ -193,6 +192,9 @@ exclude_lines = [
 [tool.coverage.run]
 source = ["app_model"]
 
+[tool.coverage.paths]
+source = ["src/", "*/app-model/app-model/src", "*/site-packages/"]
+
 [tool.check-manifest]
 ignore = [
     ".github_changelog_generator",

src/app_model/backends/qt/_qmenu.py

@@ -4,7 +4,7 @@
 from collections.abc import Collection, Iterable, Mapping, Sequence
 from typing import TYPE_CHECKING, cast
 
-from qtpy.QtWidgets import QMenu, QMenuBar, QToolBar
+from qtpy.QtWidgets import QApplication, QMenu, QMenuBar, QToolBar
 
 from app_model import Application
 from app_model.types import SubmenuItem
@@ -300,14 +300,18 @@ def _rebuild(
 
     groups = list(app.menus.iter_menu_groups(menu_id))
     n_groups = len(groups)
+    qapp = QApplication.instance()
     for n, group in enumerate(groups):
         for item in group:
             if isinstance(item, SubmenuItem):
                 if include_submenus:
                     submenu = QModelSubmenu(item, app, parent=menu)
                     cast("QMenu", menu).addMenu(submenu)
             elif item.command.id not in _exclude:
-                action = QMenuItemAction.create(item, app=app, parent=menu)
+                # use QApplication instance as parent for actions
+                # because we use action singleton, and actions
+                # are not related to any window.
+                action = QMenuItemAction.create(item, app=app, parent=qapp)
                 menu.addAction(action)
         if n < n_groups - 1:
             menu.addSeparator()