Include CI changes for testing widget frameworks

Author: gselzer

.github/workflows/ci.yml

@@ -22,28 +22,52 @@ jobs:
       - run: pipx run check-manifest
 
   lint:
-    runs-on: ubuntu-latest
+    # We lint on Windows so we can lint wx code.
+    runs-on: windows-latest
     steps:
       - uses: actions/checkout@v4
       - uses: astral-sh/setup-uv@v6
         with:
           enable-cache: true
           python-version: "3.13"
-      - uses: tox-dev/action-pre-commit-uv@v1
-        with:
-          extra_args: --all-files --verbose
+      - run: uvx pre-commit run --all-files --verbose
 
   test:
-    name: test ${{ matrix.os }} py${{ matrix.python-version }} ${{ matrix.gfx }}
+    name: test ${{ matrix.os }} py${{ matrix.python-version }} ${{ matrix.gfx }} ${{ matrix.canvas }}
     runs-on: ${{ matrix.os }}
-    env:
-      UV_FROZEN: 1
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python-version: ["3.10", "3.11", "3.12", "3.13"]
+        python-version: ["3.10", "3.13"]
         gfx: [pygfx, vispy]
+        canvas: [pyqt, jupyter, wx]
+        exclude:
+          # glfw.GLFWError: (65545) b'NSGL: Failed to find a suitable pixel format'
+          # (Under the hood GLFW gives vispy the OpenGL context.)
+          - os: macos-latest
+            canvas: jupyter
+            gfx: vispy
+          # wxpython does not build wheels for ubuntu or macos-latest py3.10
+          - os: ubuntu-latest
+            canvas: wx
+          - os: macos-latest
+            canvas: wx
+            python-version: "3.10"
+          # FIXME: On CI: AttributeError: 'Shared' object has no attribute '_device'. Did you mean: 'device'?
+          # Related to pygfx v0.13.0
+          # Tests pass locally
+          - os: windows-latest
+            gfx: pygfx
+        include:
+          - python-version: "3.11"
+            gfx: pygfx
+            canvas: pyqt
+            os: ubuntu-latest
+          - python-version: "3.12"
+            gfx: pygfx
+            canvas: pyqt
+            os: ubuntu-latest
 
     steps:
       - uses: actions/checkout@v4
@@ -61,7 +85,7 @@ jobs:
           sudo apt install -y libegl1-mesa-dev libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
 
       - name: Install dependencies
-        run: uv sync --no-dev --group test --extra ${{ matrix.gfx }} ${{ matrix.python-version != '3.10' && '--extra imgui' || '' }}
+        run: uv sync --no-dev --group test --extra ${{ matrix.gfx }} --extra ${{matrix.canvas}} ${{ matrix.python-version != '3.10' && '--extra imgui' || '' }} ${{ matrix.canvas == 'pyqt' && '--group testqt' || '' }}
 
       - name: Test
         shell: bash
@@ -70,7 +94,7 @@ jobs:
       - name: Upload coverage
         uses: actions/upload-artifact@v4
         with:
-          name: covreport-${{ matrix.os }}-py${{ matrix.python-version }}-${{ matrix.gfx }}
+          name: covreport-${{ matrix.os }}-py${{ matrix.python-version }}-${{ matrix.gfx }}-${{ matrix.canvas }}
           path: ./.coverage*
           include-hidden-files: true
 

src/scenex/adaptors/_pygfx/_canvas.py

@@ -3,7 +3,7 @@
 from typing import TYPE_CHECKING, Any, TypeGuard, cast
 
 from scenex.adaptors._base import CanvasAdaptor
-from scenex.app import app
+from scenex.app import app, determine_app, GuiFrontend
 
 from ._adaptor_registry import adaptors
 
@@ -25,13 +25,41 @@ def supports_hide_show(obj: Any) -> TypeGuard[SupportsHideShow]:
     return hasattr(obj, "show") and hasattr(obj, "hide")
 
 
+def _rendercanvas_class() -> BaseRenderCanvas:
+    """Obtains the appropriate class for the current GUI backend.
+
+    Explicit since PyGFX's backend selection process may be different from ours.
+    """
+    frontend = determine_app()
+
+    if frontend == GuiFrontend.QT:
+        from qtpy.QtCore import QSize  # pyright: ignore[reportMissingImports]
+        from rendercanvas.qt import QRenderWidget
+
+        class _QRenderWidget(QRenderWidget):
+            def sizeHint(self) -> QSize:
+                return QSize(self.width(), self.height())
+
+        # Init Qt Application - otherwise we can't create the widget
+        app()
+        return _QRenderWidget()  # type: ignore[no-untyped-call]
+
+    if frontend == GuiFrontend.JUPYTER:
+        import rendercanvas.jupyter
+
+        return rendercanvas.jupyter.JupyterRenderCanvas()
+    if frontend == GuiFrontend.WX:
+        import rendercanvas.wx
+
+        return rendercanvas.wx.WxRenderCanvas()
+
+    raise ValueError("No suitable render canvas found")
+
 class Canvas(CanvasAdaptor):
     """Canvas interface for pygfx Backend."""
 
     def __init__(self, canvas: model.Canvas, **backend_kwargs: Any) -> None:
-        from rendercanvas.auto import RenderCanvas
-
-        self._wgpu_canvas = RenderCanvas()
+        self._wgpu_canvas = _rendercanvas_class()
         # Qt RenderCanvas calls show() in its __init__ method, so we need to hide it
         if supports_hide_show(self._wgpu_canvas):
             self._wgpu_canvas.hide()

tests/app/test_jupyter.py

@@ -236,6 +236,7 @@ def test_resize(evented_canvas: snx.Canvas) -> None:
             "event_type": "resize",
             "width": new_size[0],
             "height": new_size[1],
+            "pixel_ratio": 1.0,
         }
     )
     assert evented_canvas.width == new_size[0]