Skip to content

Commit a0ee525

Browse files
chore: Adds some missing type annotations
- Adds a few missing type annotations I found while working on another project. `mypy` flagged most of these with `no-untyped-call`. The others I found while updating the functions flagged by `mypy`.
1 parent b07a89b commit a0ee525

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

jira/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,11 +732,11 @@ def _check_update_(self):
732732
except Exception as e:
733733
self.log.warning(e)
734734

735-
def __del__(self):
735+
def __del__(self) -> None:
736736
"""Destructor for JIRA instance."""
737737
self.close()
738738

739-
def close(self):
739+
def close(self) -> None:
740740
session = getattr(self, "_session", None)
741741
if session is not None:
742742
try:

jira/resources.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ def get_field(self, field_name: str) -> Any:
893893
else:
894894
return getattr(self.fields, field_name)
895895

896-
def add_field_value(self, field: str, value: str):
896+
def add_field_value(self, field: str, value: str) -> None:
897897
"""Add a value to a field that supports multiple values, without resetting the existing values.
898898
899899
This should work with: labels, multiple checkbox lists, multiple select
@@ -904,15 +904,15 @@ def add_field_value(self, field: str, value: str):
904904
"""
905905
super().update(fields={"update": {field: [{"add": value}]}})
906906

907-
def delete(self, deleteSubtasks=False):
907+
def delete(self, deleteSubtasks=False) -> None:
908908
"""Delete this issue from the server.
909909
910910
Args:
911911
deleteSubtasks (bool): True to also delete subtasks. If any are present the Issue won't be deleted (Default: ``False``)
912912
"""
913913
super().delete(params={"deleteSubtasks": deleteSubtasks})
914914

915-
def permalink(self):
915+
def permalink(self) -> str:
916916
"""Get the URL of the issue, the browsable one not the REST one.
917917
918918
Returns:

0 commit comments

Comments
 (0)