Skip to content

Conversation

@mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Nov 30, 2025

As discussed in the issue, in case some tags that are expected in the shared group now also are looked up in the first frame of the per-frame group. This may still not be the optimal solution, but should handle most cases.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

- fixed combining of errors in shared and per/frame groups
- improved handling of conditions that refer to tags in other func group sequences
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.89%. Comparing base (e8644e2) to head (abd5f16).
⚠️ Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
dicom_validator/validator/iod_validator.py 93.02% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   89.82%   88.89%   -0.94%     
==========================================
  Files          15       21       +6     
  Lines        1632     2107     +475     
==========================================
+ Hits         1466     1873     +407     
- Misses        166      234      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrbean-bremen mrbean-bremen merged commit f483ecd into pydicom:main Nov 30, 2025
17 checks passed
@mrbean-bremen mrbean-bremen deleted the func_group_cond branch November 30, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functional-group conditions misevaluate when controlling tags exist only per-frame

2 participants