Upgrade to mypy 1.12.1 #13022
Upgrade to mypy 1.12.1 #13022
Conversation
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
Could you comment "pre-commit.ci autofix" @hauntsaninja? Thanks :)
|
Thanks for the review! re Protocol: I thought we needed a different fix, but then noticed I could get away with something much simpler |
| def test_make_metadata_file_custom_contents() -> None: | ||
| value = b"hello" | ||
| f = default_make_metadata(value=value) | ||
| f = default_make_metadata(value=value) # type: ignore[arg-type] |
There was a problem hiding this comment.
Do you know the reason of this one? Is that some regression in mypy?
There was a problem hiding this comment.
Prior to mypy 1.11, mypy did not understand functools.partial at all, so calls here were effectively going unchecked. mypy now struggles a little to solve the value constrained type var once it's been partially solved in the functools.partial call.
Looking at it a little closer, the type variable in make_wheel_metadata_file is actually unnecessary, so I'll remove it to make one of the two of these go away
sbidoul
left a comment
sbidoul
left a comment
There was a problem hiding this comment.
LGTM. Could you remove the last 2 commits (1.12.1 + revert)?
|
Thanks for the review! I squashed the commits. I also landed 1.12.1 (I'd reverted because pre-commit didn't support it yet, but it does now) |
|
Thank you @hauntsaninja ! |
3 participants
No description provided.