Skip to content

Commit e693460

Browse files
committed
Ordering of login may matter
1 parent bfd5378 commit e693460

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

.github/workflows/build-root.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,24 @@ jobs:
1212
- name: Checkout code
1313
uses: actions/checkout@v5
1414

15+
- name: Set up Docker Buildx
16+
uses: docker/setup-buildx-action@v3
17+
1518
- name: Login to Github Container Registry
1619
uses: docker/login-action@v3
1720
with:
1821
registry: ghcr.io
1922
username: ${{ github.repository_owner }}
2023
password: ${{ secrets.GITHUB_TOKEN }}
2124

22-
- name: Set up Docker Buildx
23-
uses: docker/setup-buildx-action@v3
24-
2525
- name: Build and push Python builder base
2626
uses: docker/build-push-action@v6
2727
with:
2828
context: .
2929
file: ./Dockerfile.base
3030
push: true
31+
cache-to: type=inline
32+
cache-from: type=registry,ref=ghcr.io/python-discord/python-builds:builder-base
3133
tags: python-discord/python-builds:builder-base
3234

3335
resolve-versions:
@@ -39,13 +41,6 @@ jobs:
3941
- name: Checkout code
4042
uses: actions/checkout@v5
4143

42-
- name: Login to Github Container Registry
43-
uses: docker/login-action@v3
44-
with:
45-
registry: ghcr.io
46-
username: ${{ github.repository_owner }}
47-
password: ${{ secrets.GITHUB_TOKEN }}
48-
4944
- name: Run Docker container to resolve versions
5045
id: resolve_versions
5146
run: |

.github/workflows/build-version.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@ jobs:
1919
- name: Checkout code
2020
uses: actions/checkout@v5
2121

22+
- name: Set up Docker Buildx
23+
uses: docker/setup-buildx-action@v3
24+
2225
- name: Login to Github Container Registry
2326
uses: docker/login-action@v3
2427
with:
2528
registry: ghcr.io
2629
username: ${{ github.repository_owner }}
2730
password: ${{ secrets.GITHUB_TOKEN }}
2831

29-
- name: Set up Docker Buildx
30-
uses: docker/setup-buildx-action@v3
31-
3232
- name: Build and push Docker image
3333
uses: docker/build-push-action@v6
3434
with:

0 commit comments

Comments
 (0)