Skip to content

Make empty durations an error in pure-Python parser #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Make empty durations an error in pure-Python parser #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pendulum/parsing/iso8601.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def parse_iso8601(

def _parse_iso8601_duration(text: str, **options: str) -> Duration | None:
m = ISO8601_DURATION.fullmatch(text)
if not m:
if not m or (not m.group("w") and not m.group("ymd") and not m.group("hms")):
return None

years = 0
Expand Down
10 changes: 8 additions & 2 deletions tests/parsing/test_parse_iso8601.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def test_parse_iso8601(text: str, expected: date) -> None:
assert parse_iso8601(text) == expected


def test_parse_ios8601_invalid():
def test_parse_iso8601_invalid():
# Invalid month
with pytest.raises(ValueError):
parse_iso8601("20161306T123456")
Expand Down Expand Up @@ -193,7 +193,7 @@ def test_parse_ios8601_invalid():
("P2Y30M4DT5H6M7S", (2, 30, 0, 4, 5, 6, 7, 0)),
],
)
def test_parse_ios8601_duration(
def test_parse_iso8601_duration(
text: str, expected: tuple[int, int, int, int, int, int, int, int]
) -> None:
parsed = parse_iso8601(text)
Expand All @@ -208,3 +208,9 @@ def test_parse_ios8601_duration(
parsed.remaining_seconds,
parsed.microseconds,
) == expected


def test_parse_iso8601_duration_invalid():
# Must include at least one element
with pytest.raises(ValueError):
parse_iso8601("P")