Add GLOO_LOG_LEVEL env #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4l3k
approved these changes
Sep 12, 2025
gloo/common/logging.cc
Outdated
| const char* level = getenv("GLOO_LOG_LEVEL"); | ||
| // Defaults to ERROR. | ||
| if (level == nullptr) { | ||
| log_level = LogLevel::ERROR; |
There was a problem hiding this comment.
Can we make this match PyTorch (which I think is WARN?)
| return log_level; | ||
| } | ||
|
|
||
| const char* level = getenv("GLOO_LOG_LEVEL"); |
There was a problem hiding this comment.
Also, the info logs are currently very important for debugging production jobs. Can we also check LOGLEVEL and use that value if GLOO_LOG_LEVEL isn't set?
There was a problem hiding this comment.
Sorry, what and where is LOGLEVEL? I don't have enough context.
fduwjj
approved these changes
Sep 12, 2025
youkaichao
reviewed
Oct 21, 2025
|
@youkaichao merged now. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepted values:
ERROR, WARN, INFO, DEBUG
Default value:
WARN