Remove needsToken logic from ConnectionData

This was introduced as a workaround for cases when homeservers
require authentication on media endpoints, deviating from the spec text
of that time in order to protect themselves. This workaround is not
necessary since #776; DownloadFileJob and MediaThumbnailJob now always
supply the access token even when the homeserver doesn't require it.

Author: KitsuneRal

Quotient/connectiondata.cpp

@@ -30,7 +30,6 @@ class ConnectionData::Private {
     QString userId;
     QString deviceId;
     QStringList supportedSpecVersions;
-    std::vector<QString> needToken;
 
     mutable unsigned int txnCounter = 0;
     const qint64 txnBase = QDateTime::currentMSecsSinceEpoch();
@@ -134,12 +133,6 @@ const QString& ConnectionData::deviceId() const { return d->deviceId; }
 
 const QString& ConnectionData::userId() const { return d->userId; }
 
-bool ConnectionData::needsToken(const QString& requestName) const
-{
-    return std::find(d->needToken.cbegin(), d->needToken.cend(), requestName)
-           != d->needToken.cend();
-}
-
 void ConnectionData::setDeviceId(const QString& deviceId)
 {
     d->deviceId = deviceId;
@@ -156,11 +149,6 @@ void ConnectionData::setUserId(const QString& userId)
     d->userId = userId;
 }
 
-void ConnectionData::setNeedsToken(const QString& requestName)
-{
-    d->needToken.push_back(requestName);
-}
-
 void ConnectionData::setSupportedSpecVersions(QStringList versions)
 {
     qCInfo(MAIN).noquote() << "CS API versions:" << versions.join(u' ');

Quotient/connectiondata.h

@@ -28,15 +28,13 @@ class QUOTIENT_API ConnectionData {
     QUrl baseUrl() const;
     const QString& deviceId() const;
     const QString& userId() const;
-    bool needsToken(const QString& requestName) const;
     HomeserverData homeserverData() const;
     Quotient::NetworkAccessManager *nam() const;
 
     void setBaseUrl(QUrl baseUrl);
     void setToken(QByteArray accessToken);
     void setDeviceId(const QString& deviceId);
     void setUserId(const QString& userId);
-    void setNeedsToken(const QString& requestName);
     void setSupportedSpecVersions(QStringList versions);
 
     QString lastEvent() const;

Quotient/jobs/basejob.cpp

@@ -381,7 +381,6 @@ void BaseJob::sendRequest()
         return;
     }
     Q_ASSERT(d->connection && status().code == Pending);
-    d->needsToken |= d->connection->needsToken(objectName());
     auto req = d->prepareRequest();
     emit aboutToSendRequest(&req);
     d->sendRequest(req);
@@ -601,17 +600,6 @@ void BaseJob::finishJob()
         emit rateLimited();
         d->connection->submit(this);
         return;
-    case Unauthorised:
-        if (!d->needsToken && !d->connection->accessToken().isEmpty()) {
-            // Rerun with access token (extension of the spec while
-            // https://github.com/matrix-org/matrix-doc/issues/701 is pending)
-            d->connection->setNeedsToken(objectName());
-            qCWarning(d->logCat) << this << "re-running with authentication";
-            emit retryScheduled(d->retriesTaken, 0);
-            d->connection->submit(this);
-            return;
-        }
-        break;
     case NetworkError:
     case IncorrectResponse:
     case Timeout: