-
Notifications
You must be signed in to change notification settings - Fork 71
Cleaning the code base #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Nice thanks for doing this. I will have a look, but try to avoid exploding the PR. Let's keep the size as small as possible (At the moment it seems ok, maybe move the qasm and circuit drawer change to a different one.). I just noticed that in the last PR the test_qiskit was mistakely commented out in the end, which I missed. Also to avoid having to manually slient the qiskit test, I would recomment to create a different branch instead of using master and create a new environment, either using conda or virtual env. So the development won't affect your existing environment. And you can have multiple version at the sametime. This is good practice in general. |
|
Sure, I will keep this in mind. I will move qasm, circuit to a different PR, those refactor are pretty huge. |
qutip_qip.circuit import QubitCircuit) instead of relative..circuit import QubitCircuit. This helps when files are moved around or refactored.qasm.pyhas been broken down into a module since the no. of lines of code was over 1300 (the external import structure remains the same), separatedModelinto a separate file, renderers were refactored into a module namedrawundersrc/circuits@BoxiLi This PR isn't fully finished yet, its still a draft. But can you review it please since the code changes especially refactor is pretty huge.