♻️ Eliminate unnecessary hash state

Because of Identification.global_id_column, we can keep this internal
API much cleaner and avoid mucking with hash state to pass around this
column

Author: tylerwillingham

lib/global_id/global_id.rb

@@ -11,7 +11,6 @@ class << self
     def create(model, options = {})
       if app = options.fetch(:app) { GlobalID.app }
         params = options.except(:app, :verifier, :for)
-        params[:global_id_column] ||= model.global_id_column
         new URI::GID.create(app, model, params), options
       else
         raise ArgumentError, 'An app is required to create a GlobalID. ' \

lib/global_id/uri/gid.rb

@@ -72,12 +72,7 @@ def parse(uri)
       #
       #   URI::GID.create('bcx', Person.find(5), database: 'superhumans')
       def create(app, model, params = nil)
-        global_id_column = params&.delete(:global_id_column)
-        model_id_method = if model.id.is_a?(Array)
-                            :id
-                          else
-                            global_id_column
-                          end || :id
+        model_id_method = model.id.is_a?(Array) ? :id : model.global_id_column
 
         build app: app, model_name: model.class.name, model_id: model.send(model_id_method), params: params
       end

test/cases/uri_gid_test.rb

@@ -46,7 +46,7 @@ class URI::GIDTest <  ActiveSupport::TestCase
 
   test 'create from a configurable key model' do
     model = ConfigurableKeyModel.new(id: 'id-value', external_id: 'external-id-123')
-    assert_equal @ckm_gid_string, URI::GID.create('bcx', model, global_id_column: :external_id).to_s
+    assert_equal @ckm_gid_string, URI::GID.create('bcx', model).to_s
   end
 
   test 'build' do