Extract common regexp to constants and methods

This make sure we are not duplicating the same regexp in multiple places
with slightly different variations.

Author: rafaelfranca

lib/importmap/commands.rb

@@ -117,10 +117,12 @@ def npm
     end
 
     def update_importmap_with_pin(package, pin)
+      new_pin = "#{pin}\n"
+
       if packager.packaged?(package)
-        gsub_file("config/importmap.rb", /^pin "#{package}".*$/, pin, verbose: false)
+        gsub_file("config/importmap.rb", Importmap::Map.pin_line_regexp_for(package), new_pin, verbose: false)
       else
-        append_to_file("config/importmap.rb", "#{pin}\n", verbose: false)
+        append_to_file("config/importmap.rb", new_pin, verbose: false)
       end
     end
 

lib/importmap/map.rb

@@ -3,6 +3,12 @@
 class Importmap::Map
   attr_reader :packages, :directories
 
+  PIN_REGEX = /^pin\s+["']([^"']+)["']/.freeze # :nodoc:
+
+  def self.pin_line_regexp_for(package) # :nodoc:
+    /^.*pin\s+["']#{Regexp.escape(package)}["'].*$/.freeze
+  end
+
   class InvalidFile < StandardError; end
 
   def initialize

lib/importmap/npm.rb

@@ -3,7 +3,7 @@
 require "json"
 
 class Importmap::Npm
-  PIN_REGEX = /^pin ["']([^["']]*)["'].*/
+  PIN_REGEX = /#{Importmap::Map::PIN_REGEX}.*/.freeze # :nodoc:
 
   Error     = Class.new(StandardError)
   HTTPError = Class.new(Error)

lib/importmap/packager.rb

@@ -3,6 +3,8 @@
 require "json"
 
 class Importmap::Packager
+  PIN_REGEX = /#{Importmap::Map::PIN_REGEX}(.*)/.freeze # :nodoc:
+
   Error        = Class.new(StandardError)
   HTTPError    = Class.new(Error)
   ServiceError = Error.new(Error)
@@ -51,7 +53,7 @@ def vendored_pin_for(package, url, preloads = nil)
   end
 
   def packaged?(package)
-    importmap.match(/^pin ["']#{package}["'].*$/)
+    importmap.match(Importmap::Map.pin_line_regexp_for(package))
   end
 
   def download(package, url)
@@ -129,7 +131,7 @@ def remove_existing_package_file(package)
 
     def remove_package_from_importmap(package)
       all_lines = File.readlines(@importmap_path)
-      with_lines_removed = all_lines.grep_v(/pin ["']#{package}["']/)
+      with_lines_removed = all_lines.grep_v(Importmap::Map.pin_line_regexp_for(package))
 
       File.open(@importmap_path, "w") do |file|
         with_lines_removed.each { |line| file.write(line) }