Skip to content

Commit 267b117

Browse files
authored
Merge pull request #97 from ghiculescu/blank-body
Better error message if response.body is blank or not parseable by Nokogiri
2 parents f442cd2 + 94783d5 commit 267b117

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

lib/rails/dom/testing/assertions/selector_assertions.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,7 @@ def nodeset(node)
297297
if node.is_a?(Nokogiri::XML::NodeSet)
298298
node
299299
else
300+
node ||= Nokogiri::HTML::Document.new
300301
Nokogiri::XML::NodeSet.new(node.document, [node])
301302
end
302303
end

test/selector_assertions_test.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,14 @@ def test_assert_select_with_extra_argument
327327
assert_select "title", text: "Welcome", count: 1
328328
end
329329

330+
def test_assert_select_on_blank_response
331+
render_html ""
332+
assert_select "div", 0
333+
assert_failure(/Expected exactly 1 element matching \"div\", found 0./) do
334+
assert_select "div", 1
335+
end
336+
end
337+
330338
protected
331339
def render_html(html)
332340
fake_render(:html, html)

0 commit comments

Comments
 (0)