Skip to content

Commit 18b7947

Browse files
committed
Fixing a warning around importDrawer we would see when creating new extensions
1 parent 8840e26 commit 18b7947

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

scripts/check-i18n-links

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ if (docsBaseUrl.length === 0) {
7171
process.exit(1);
7272
}
7373

74-
const versionFile = fs.readFileSync(path.join(srcFolder, 'config', 'version.js'), 'utf8');
74+
const versionFile = fs.readFileSync(path.join(srcFolder, 'config', 'version.ts'), 'utf8');
7575
const versionFileMatches = versionFile.match(VERSION_REGEX);
7676

7777
if (versionFileMatches && versionFileMatches.length === 2) {
@@ -137,7 +137,7 @@ function parseLinks(str) {
137137
if (link.startsWith('http')) {
138138
links.push(link);
139139
} else if (!(link.startsWith('{') && link.endsWith('}'))) {
140-
console.log(`${ yellow }${bold}Skipping link: ${ link }${ reset }`); // eslint-disable-line no-console
140+
console.log(`${ yellow }${ bold }Skipping link: ${ link }${ reset }`); // eslint-disable-line no-console
141141
}
142142
}
143143
});
@@ -184,7 +184,6 @@ console.log(''); // eslint-disable-line no-console
184184
console.log(`Using documentation base URL: ${ cyan }${ docsBaseUrl }${ reset }`); // eslint-disable-line no-console
185185
console.log(''); // eslint-disable-line no-console
186186

187-
188187
console.log('Reading translation files:'); // eslint-disable-line no-console
189188

190189
let i18n = loadI18nFiles(srcFolder);
File renamed without changes.

shell/config/version.js renamed to shell/config/version.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export function getVersionData() {
1616
return _versionData;
1717
}
1818

19-
export function setVersionData(v) {
19+
export function setVersionData(v: any) {
2020
// Remove any properties on 'v' we don't want
2121
_versionData = JSON.parse(JSON.stringify(v));
2222
}
@@ -25,7 +25,7 @@ export function getKubeVersionData() {
2525
return _kubeVersionData;
2626
}
2727

28-
export function setKubeVersionData(v) {
28+
export function setKubeVersionData(v: any) {
2929
// Remove any properties on 'v' we don't want
3030
_kubeVersionData = JSON.parse(JSON.stringify(v));
3131
}

shell/pkg/dynamic-importer.lib.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ export function importDialog(name) {
3333
return () => undefined;
3434
}
3535

36+
export function importDrawer(name) {
37+
return () => undefined;
38+
}
39+
3640
export function listProducts() {
3741
return [];
3842
}

0 commit comments

Comments
 (0)