Skip to content

Commit d974354

Browse files
committed
chore: use constant for manager port
Signed-off-by: Chin-Ya Huang <[email protected]>
1 parent 89473bf commit d974354

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

pkg/manager/httpserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func (s *HttpServer) Run(m *SupportBundleManager) {
110110
r.Path("/nodes/{nodeName}").Methods("POST").HandlerFunc(s.createNodeBundle)
111111

112112
server := &http.Server{
113-
Addr: ":8080",
113+
Addr: ":" + ManagerPort,
114114
Handler: r,
115115
ReadTimeout: defaultTimeout,
116116
WriteTimeout: defaultTimeout,

pkg/manager/manager.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ func (m *SupportBundleManager) collectNodeBundles() error {
362362

363363
// create a daemonset to collect node bundles and push back
364364
agents := &AgentDaemonSet{sbm: m}
365-
agentDaemonSet, err := agents.Create(m.ImageName, fmt.Sprintf("http://%s", net.JoinHostPort(m.ManagerPodIP, "8080")))
365+
agentDaemonSet, err := agents.Create(m.ImageName, fmt.Sprintf("http://%s", net.JoinHostPort(m.ManagerPodIP, ManagerPort)))
366366
if err != nil {
367367
return err
368368
}

pkg/manager/types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ const (
1010
PhaseDone = "done"
1111

1212
BundleVersion = "0.1.0"
13+
14+
ManagerPort = "8080"
1315
)
1416

1517
type BundleMeta struct {

0 commit comments

Comments
 (0)