test: use constant for TestGenerateNodeZipObjects expectations

Signed-off-by: Chin-Ya Huang <[email protected]>

Author: c3y1huang

pkg/simulator/objects/process_node_zips_test.go

@@ -37,6 +37,14 @@ func TestGenerateNodeZipList(t *testing.T) {
 }
 
 func TestGenerateNodeZipObjects(t *testing.T) {
+	const (
+		expectedPodCount       = 2
+		expectedPodName        = "harvester-node-0"
+		expectedContainerCount = 11
+		expectedConfigLength   = 2
+		expectedFileCount      = 30
+	)
+
 	tmpDir, err := os.MkdirTemp("/tmp", "zipfiles-")
 	if err != nil {
 		t.Fatalf("Error creating tmp directory %v", err)
@@ -61,26 +69,26 @@ func TestGenerateNodeZipObjects(t *testing.T) {
 	}
 
 	// verify pod
-	if len(podList) != 2 {
-		t.Fatalf("expected to find 1 pod created to match the node, but found %d", len(podList))
+	if len(podList) != expectedPodCount {
+		t.Fatalf("expected to find %d pod created to match the node, but found %d", expectedPodCount, len(podList))
 	}
 
 	// parse containers in the pod
 	node1Pod := podList[0]
-	if node1Pod.Name != "harvester-node-0" {
-		t.Fatalf("expected pod name to be node1 but got %s", node1Pod.Name)
+	if node1Pod.Name != expectedPodName {
+		t.Fatalf("expected pod name to be %s but got %s", expectedPodName, node1Pod.Name)
 	}
 
-	if len(node1Pod.Spec.Containers) != 11 {
-		t.Fatalf("expected 11 containers but found %d", len(node1Pod.Spec.Containers))
+	if len(node1Pod.Spec.Containers) != expectedContainerCount {
+		t.Fatalf("expected %d containers but found %d", expectedContainerCount, len(node1Pod.Spec.Containers))
 	}
 
-	if len(nodeConfig) != 2 {
-		t.Fatalf("expected to find 1 node but found %d", len(nodeConfig))
+	if len(nodeConfig) != expectedConfigLength {
+		t.Fatalf("expected to find %d node but found %d", expectedConfigLength, len(nodeConfig))
 	}
 
 	// parse content
-	if len(nodeConfig[0].Spec) != 30 {
-		t.Fatalf("expected to find 30 files, but found %d", len(nodeConfig[0].Spec))
+	if len(nodeConfig[0].Spec) != expectedFileCount {
+		t.Fatalf("expected to find %d files, but found %d", expectedFileCount, len(nodeConfig[0].Spec))
 	}
 }