Skip to content

Commit b32ada4

Browse files
committed
fix: Fix #157
Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
1 parent 4c57241 commit b32ada4

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

pkg/provider/aws/action/fedora/fedora.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
1717
"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
1818
securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
19+
"github.com/adrianriobo/qenvs/pkg/provider/util/command"
1920
"github.com/adrianriobo/qenvs/pkg/provider/util/output"
2021
"github.com/adrianriobo/qenvs/pkg/util"
2122
resourcesUtil "github.com/adrianriobo/qenvs/pkg/util/resources"
@@ -191,7 +192,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
191192
pulumi.String(amiUserDefault))
192193
ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
193194
c.GetHostIP(!r.Airgap))
194-
return c.Readiness(ctx, r.Prefix, awsFedoraDedicatedID,
195+
return c.Readiness(ctx, command.CommandPing, r.Prefix, awsFedoraDedicatedID,
195196
keyResources.PrivateKey, amiUserDefault, bastion, []pulumi.Resource{})
196197
}
197198

pkg/provider/aws/action/rhel/rhel.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
1919
"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
2020
securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
21+
"github.com/adrianriobo/qenvs/pkg/provider/util/command"
2122
"github.com/adrianriobo/qenvs/pkg/provider/util/output"
2223
"github.com/adrianriobo/qenvs/pkg/util"
2324
"github.com/adrianriobo/qenvs/pkg/util/file"
@@ -217,7 +218,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
217218
pulumi.String(amiUserDefault))
218219
ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
219220
c.GetHostIP(!r.Airgap))
220-
return c.Readiness(ctx, r.Prefix, awsRHELDedicatedID,
221+
return c.Readiness(ctx, command.CommandCloudInitWait, r.Prefix, awsRHELDedicatedID,
221222
keyResources.PrivateKey, amiUserDefault, bastion, []pulumi.Resource{})
222223
}
223224

pkg/provider/aws/action/windows/windows.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
amiSVC "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/ami"
2020
"github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/keypair"
2121
securityGroup "github.com/adrianriobo/qenvs/pkg/provider/aws/services/ec2/security-group"
22+
"github.com/adrianriobo/qenvs/pkg/provider/util/command"
2223
"github.com/adrianriobo/qenvs/pkg/provider/util/output"
2324
"github.com/adrianriobo/qenvs/pkg/provider/util/security"
2425
"github.com/adrianriobo/qenvs/pkg/util"
@@ -253,7 +254,7 @@ func (r *Request) deploy(ctx *pulumi.Context) error {
253254
password.Result)
254255
ctx.Export(fmt.Sprintf("%s-%s", r.Prefix, outputHost),
255256
c.GetHostIP(!r.Airgap))
256-
return c.Readiness(ctx, r.Prefix, awsWindowsDedicatedID,
257+
return c.Readiness(ctx, command.CommandPing, r.Prefix, awsWindowsDedicatedID,
257258
keyResources.PrivateKey, r.AMIUser, bastion, []pulumi.Resource{})
258259
}
259260

pkg/provider/aws/modules/ec2/compute/compute.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,9 @@ func (c *Compute) GetHostIP(public bool) (ip pulumi.StringInput) {
197197
return c.LB.DnsName
198198
}
199199

200-
// Check if compute is healthy (ping on ssh)
200+
// Check if compute is healthy based on running a remote cmd
201201
func (compute *Compute) Readiness(ctx *pulumi.Context,
202+
cmd string,
202203
prefix, id string,
203204
mk *tls.PrivateKey, username string,
204205
b *bastion.Bastion,
@@ -207,8 +208,8 @@ func (compute *Compute) Readiness(ctx *pulumi.Context,
207208
resourcesUtil.GetResourceName(prefix, id, "readiness-cmd"),
208209
&remote.CommandArgs{
209210
Connection: remoteCommandArgs(compute, mk, username, b),
210-
Create: pulumi.String(command.CommandPing),
211-
Update: pulumi.String(command.CommandPing),
211+
Create: pulumi.String(cmd),
212+
Update: pulumi.String(cmd),
212213
}, pulumi.Timeouts(
213214
&pulumi.CustomTimeouts{
214215
Create: command.RemoteTimeout,

0 commit comments

Comments
 (0)