Skip to content

Commit aa94f5c

Browse files
snjezafbricon
authored andcommitted
Global 'java.jdt.ls.vmargs' setting is ignored
Signed-off-by: Snjezana Peco <[email protected]>
1 parent 2c5e010 commit aa94f5c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/javaServerStarter.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ function prepareParams(requirements: RequirementsData, javaConfiguration, worksp
7272
vmargsCheck = workspace.getConfiguration().inspect('java.jdt.ls.vmargs').globalValue;
7373
}
7474
}
75+
} else {
76+
vmargsCheck = getJavaConfiguration().get('jdt.ls.vmargs');
7577
}
7678
let vmargs;
7779
if (vmargsCheck !== undefined) {

src/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export async function checkJavaPreferences(context: ExtensionContext) {
125125
let javaHome = workspace.getConfiguration().inspect<string>('java.home').workspaceValue;
126126
let isVerified = javaHome === undefined || javaHome === null;
127127
if (isVerified) {
128-
javaHome = workspace.getConfiguration().inspect<string>('java.home').globalValue;
128+
javaHome = getJavaConfiguration().get('home');
129129
}
130130
const allow = 'Allow';
131131
const disallow = 'Disallow';

0 commit comments

Comments
 (0)