Remove the legacy validation functionality

Author: Marek Suchánek

docs/using-newdoc.adoc

@@ -252,28 +252,6 @@ When generating a new file, `newdoc` warns you if a file by that name already ex
 * Preserve the existing file and cancel the newly generated file.
 
 
-== (Deprecated) Validating a file for Red Hat requirements
-
-You can use the `--validate` (`-l`) option to check an existing file for Red Hat publishing requirements. For example:
-
-----
-$ newdoc --validate modules/empty-file.adoc
-
-💾 File: empty-file.adoc
-    🔴 Error: The file has no title or headings.
-    🔴 Error: The file is missing an ID.
-    🔶 Warning: The file is missing the _abstract flag. The flag is recommended but not required.
-    🔴 Error: Cannot determine the module type.
-----
-
-----
-$ newdoc --validate modules/con_proper-module.adoc
-
-💾 File: modules/con_proper-module.adoc
-    🔷 Information: No issues found in this file.
-----
-
-
 == Options
 
 * To generate the file with explanatory comments, add the `--comments` or `-M` option when creating documents.

src/cmd_line.rs

@@ -98,8 +98,10 @@ pub struct Action {
     #[bpaf(short, long, argument("TITLE"))]
     pub include_in: Option<String>,
 
-    /// DEPRECATED: Validate (lint) an existing module or assembly file
-    #[bpaf(short('l'), long, argument("FILE"))]
+    /// REMOVED: Validate (lint) an existing module or assembly file
+    /// The option is hidden, has no effect, and exists only for compatibility
+    /// with previous releases.
+    #[bpaf(short('l'), long, argument("FILE"), hide)]
     pub validate: Vec<PathBuf>,
 }
 

src/lib.rs

@@ -35,13 +35,12 @@ along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 use std::path::PathBuf;
 
-use color_eyre::eyre::{bail, eyre, Result, WrapErr};
+use color_eyre::eyre::{bail, Result};
 
 pub mod cmd_line;
 mod logging;
 mod module;
 mod templating;
-mod validation;
 mod write;
 
 use cmd_line::{Cli, Verbosity};
@@ -104,8 +103,8 @@ pub fn run(options: &Options, cli: &Cli) -> Result<()> {
 
     // Report any deprecated options.
     if !cli.action.validate.is_empty() {
-        log::warn!("The validation feature is deprecated and will be removed in a later version.\n\
-                   Please switch to the `enki` validation tool: <https://github.com/Levi-Leah/enki/>.");
+        log::warn!("The validation feature has been removed. \
+                   Please switch to the Enki validation tool: <https://github.com/Levi-Leah/enki/>.");
     }
     if cli.common_options.no_comments {
         log::warn!(
@@ -165,11 +164,6 @@ pub fn run(options: &Options, cli: &Cli) -> Result<()> {
         populated.write_file(options)?;
     }
 
-    // Validate all file names specified on the command line
-    for file in &cli.action.validate {
-        validation::validate(file).wrap_err_with(|| eyre!("Failed to validate file {:?}", file))?;
-    }
-
     Ok(())
 }