Skip to content

Fixed time conversion, reduced memory footprint, enabled s/publish, added node-redis benchmark #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipecosta90 merged 7 commits into from
Apr 24, 2025
Merged

Fixed time conversion, reduced memory footprint, enabled s/publish, added node-redis benchmark #28

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bdca91d
Fix time conversions on the subscriber side
htemelski-oss Apr 16, 2025
481a4f9
minor fix
htemelski-oss Apr 16, 2025
d481e62
Use only milliseconds
htemelski-oss Apr 16, 2025
926fca4
Reduced the memory footprint of the js benchmark
htemelski-oss Apr 16, 2025
5ad049f
Enable s/publish
htemelski-oss Apr 16, 2025
8abff88
Merge pull request #1 from htemelski/reduce_memory_footprint
htemelski Apr 16, 2025
a90c201
Added node-redis benchmark implementation
htemelski-oss Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/lib/publisher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ async function publisherRoutine(
while (isRunningRef.value) {
let msg = payload;
if (measureRTT) {
msg = process.hrtime.bigint() / 1000;
msg = process.hrtime.bigint() / 1000n;
}

for (const channel of channels) {
Expand Down
2 changes: 1 addition & 1 deletion js/lib/subscriber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ async function subscriberRoutine(

if (measureRTT) {
try {
const now = BigInt(Date.now()) * 1000n;
const now = process.hrtime.bigint() / 1000n;
const timestamp = BigInt(message); // µs
const rtt = now - timestamp;

Expand Down