-
Notifications
You must be signed in to change notification settings - Fork 19
Document Docker image locations and default to development mode #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
abrookins
commented
Oct 7, 2025
- Add Docker Hub and GitHub Packages registry URLs to README
- Add OCI labels to Dockerfile for better registry metadata
- Change default CMD to use --no-worker for simpler quickstart
- Document production deployment pattern with separate containers
- Add Docker Hub and GitHub Packages registry URLs to README - Add OCI labels to Dockerfile for better registry metadata - Change default CMD to use --no-worker for simpler quickstart - Document production deployment pattern with separate containers - Explain why Docker Hub overview may appear empty and how to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves Docker deployment documentation and configuration by adding registry URLs, OCI labels, and defaulting to development mode for easier quickstart. The changes make the project more discoverable on container registries and provide clearer deployment patterns.
- Documents Docker Hub and GitHub Packages locations for pre-built images
- Adds comprehensive OCI labels to improve registry metadata and discoverability
- Changes default CMD to development mode (--no-worker) for simpler initial setup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds Docker registry URLs, usage examples, and reorganizes deployment documentation |
| Dockerfile | Adds OCI labels and changes default CMD to development mode with detailed comments |
| docker-compose.yml | Adds clarifying comment about default CMD behavior |
| agent_memory_server/models.py | Removes duplicate ClientMemoryRecord class and imports from client package |
Comments suppressed due to low confidence (2)
README.md:1
- Corrected spelling of 'Docket' to 'Docker'.
# Redis Agent Memory Server
README.md:1
- Corrected spelling of 'Docket' to 'Docker'.
# Redis Agent Memory Server
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.
Repository Risks:
- Critical Severity Findings: Indicates that the resource has critical severity security findings that need immediate action.
- Database Integration: Connects to a database, often involving sensitive data that must be securely managed.
- Production: Critical as it operates in a live production environment, directly impacting users and business operations.
Repository Context:
graph LR
GitHub$Repository_U23_redis/agent_U2D_memory_U2D_server["GitHub Repository<br/>redis/agent-memory-server"]:::GitHub$Repository
Team_U23_applied_U2D_ai["Team<br/>applied-ai"]:::Team
DBIntegration_U23_redis["DBIntegration<br/>redis"]:::DBIntegration
GitHub$Actions_U23_agent_U2D_memory_U2D_client_U2E_yml["GitHub Actions<br/>agent-memory-client.yml"]:::GitHub$Actions
Team_U23_applied_U2D_ai -- "Owns" --> GitHub$Repository_U23_redis/agent_U2D_memory_U2D_server
GitHub$Repository_U23_redis/agent_U2D_memory_U2D_server -- "Is accessible to" --> DBIntegration_U23_redis
GitHub$Repository_U23_redis/agent_U2D_memory_U2D_server -- "Has" --> GitHub$Actions_U23_agent_U2D_memory_U2D_client_U2E_yml
Addresses security finding by adding dedicated agentmemory user. Prevents privilege escalation if container is compromised.
Change 'cmd' to 'command' on line 63 for api-for-task-worker service. Also remove --no-worker flag from command since this service is meant to work with a separate task-worker container.