Skip to content

Commit 668953d

Browse files
add back service to actions workflow for the notebook test
1 parent 9ed8fb7 commit 668953d

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

.github/workflows/test.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@ env:
1818

1919
jobs:
2020
test:
21-
name: Python ${{ matrix.python-version }} - ${{ matrix.connection }} [redis-stack ${{matrix.redis-stack-version}}]
21+
name: Python ${{ matrix.python-version }} - ${{ matrix.connection }} [redis ${{matrix.redis-version}}]
2222
runs-on: ubuntu-latest
2323

24+
services:
25+
redis:
26+
image: redis/redis-stack-server:${{matrix.redis-version}}
27+
ports:
28+
- 6379:6379
29+
2430
strategy:
2531
fail-fast: false
2632
matrix:
2733
python-version: [3.9, '3.10', 3.11, 3.12, 3.13]
2834
connection: ['hiredis', 'plain']
29-
redis-stack-version: ['6.2.6-v9', 'latest', 'edge', '8.0-M03']
30-
31-
# services:
32-
# redis:
33-
# image: ${{ env.REDIS_IMAGE }}
34-
# ports:
35-
# - 6379:6379
35+
redis-version: ['6.2.6-v9', 'latest', '8.0-M03']
3636

3737
steps:
3838
- name: Check out repository
@@ -60,10 +60,10 @@ jobs:
6060
6161
- name: Set Redis image name
6262
run: |
63-
if [[ "${{ matrix.redis-stack-version }}" == "8.0-M03" ]]; then
64-
echo "REDIS_IMAGE=redis:${{ matrix.redis-stack-version }}" >> $GITHUB_ENV
63+
if [[ "${{ matrix.redis-version }}" == "8.0-M03" ]]; then
64+
echo "REDIS_IMAGE=redis:${{ matrix.redis-version }}" >> $GITHUB_ENV
6565
else
66-
echo "REDIS_IMAGE=redis/redis-stack-server:${{ matrix.redis-stack-version }}" >> $GITHUB_ENV
66+
echo "REDIS_IMAGE=redis/redis-stack-server:${{ matrix.redis-version }}" >> $GITHUB_ENV
6767
fi
6868
6969
- name: Authenticate to Google Cloud
@@ -72,7 +72,7 @@ jobs:
7272
credentials_json: ${{ secrets.GOOGLE_CREDENTIALS }}
7373

7474
- name: Run tests
75-
if: matrix.connection == 'plain' && matrix.redis-stack-version == 'latest'
75+
if: matrix.connection == 'plain' && matrix.redis-version == 'latest'
7676
env:
7777
OPENAI_API_KEY: ${{ secrets.OPENAI_KEY }}
7878
GCP_LOCATION: ${{ secrets.GCP_LOCATION }}
@@ -90,12 +90,12 @@ jobs:
9090
make test-all
9191
9292
- name: Run tests
93-
if: matrix.connection != 'plain' || matrix.redis-stack-version != 'latest'
93+
if: matrix.connection != 'plain' || matrix.redis-version != 'latest'
9494
run: |
9595
make test
9696
9797
- name: Run notebooks
98-
if: matrix.connection == 'plain' && matrix.redis-stack-version == 'latest'
98+
if: matrix.connection == 'plain' && matrix.redis-version == 'latest'
9999
env:
100100
OPENAI_API_KEY: ${{ secrets.OPENAI_KEY }}
101101
GCP_LOCATION: ${{ secrets.GCP_LOCATION }}

tests/conftest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ def redis_container(request):
2525

2626
# Set the Compose project name so containers do not clash across workers
2727
os.environ["COMPOSE_PROJECT_NAME"] = f"redis_test_{worker_id}"
28-
os.environ.setdefault(
29-
"REDIS_IMAGE", "redis:8.0-M03"
30-
) # "redis/redis-stack-server:edge")
28+
os.environ.setdefault("REDIS_IMAGE", "redis/redis-stack-server:latest")
3129

3230
compose = DockerCompose(
3331
context="tests",

0 commit comments

Comments
 (0)