adds TextQuery class

Author: justin-cechmanek

redisvl/query/__init__.py

@@ -2,7 +2,9 @@
     BaseQuery,
     CountQuery,
     FilterQuery,
+    HybridQuery,
     RangeQuery,
+    TextQuery,
     VectorQuery,
     VectorRangeQuery,
 )
@@ -14,4 +16,6 @@
     "RangeQuery",
     "VectorRangeQuery",
     "CountQuery",
+    "TextQuery",
+    "HybridQuery",
 ]

redisvl/query/query.py

@@ -1,5 +1,6 @@
 from typing import Any, Dict, List, Optional, Union
 
+from redis.commands.search.aggregation import AggregateRequest, Desc
 from redis.commands.search.query import Query as RedisQuery
 
 from redisvl.query.filter import FilterExpression
@@ -136,7 +137,7 @@ def __init__(
         """A query for a simple count operation provided some filter expression.
 
         Args:
-            filter_expression (Optional[Union[str, FilterExpression]]): The filter expression to 
+            filter_expression (Optional[Union[str, FilterExpression]]): The filter expression to
                 query with. Defaults to None.
             params (Optional[Dict[str, Any]], optional): The parameters for the query. Defaults to None.
 
@@ -406,31 +407,32 @@ class RangeQuery(VectorRangeQuery):
 
 class TextQuery(FilterQuery):
     def __init__(
-        self, 
+        self,
         text: str,
         text_field: str,
-        text_scorer: str = "TFIDF",
-        return_fields: Optional[List[str]] = None,
+        text_scorer: str = "BM25",
         filter_expression: Optional[Union[str, FilterExpression]] = None,
+        return_fields: Optional[List[str]] = None,
         num_results: int = 10,
         return_score: bool = True,
         dialect: int = 2,
         sort_by: Optional[str] = None,
         in_order: bool = False,
+        params: Optional[Dict[str, Any]] = None,
     ):
         """A query for running a full text and vector search, along with an optional
         filter expression.
 
         Args:
-            text (str): The text string to perform the text search with. 
+            text (str): The text string to perform the text search with.
             text_field (str): The name of the document field to perform text search on.
             text_scorer (str, optional): The text scoring algorithm to use.
-                Defaults to TFIDF. Options are {TFIDF, BM25, DOCNORM, DISMAX, DOCSCORE}.
+                Defaults to BM25. Options are {TFIDF, BM25, DOCNORM, DISMAX, DOCSCORE}.
                 See https://redis.io/docs/latest/develop/interact/search-and-query/advanced-concepts/scoring/
+            filter_expression (Union[str, FilterExpression], optional): A filter to apply
+                along with the text search. Defaults to None.
             return_fields (List[str]): The declared fields to return with search
                 results.
-            filter_expression (Union[str, FilterExpression], optional): A filter to apply
-                along with the vector search. Defaults to None.
             num_results (int, optional): The top k results to return from the
                 search. Defaults to 10.
             return_score (bool, optional): Whether to return the text score.
@@ -442,174 +444,82 @@ def __init__(
             in_order (bool): Requires the terms in the field to have
                 the same order as the terms in the query filter, regardless of
                 the offsets between them. Defaults to False.
-
-        Raises:
-            TypeError: If filter_expression is not of type redisvl.query.FilterExpression
+            params (Optional[Dict[str, Any]], optional): The parameters for the query.
+                Defaults to None.
         """
+        import nltk
+        from nltk.corpus import stopwords
+
+        nltk.download("stopwords")
+        self._stopwords = set(stopwords.words("english"))
+
+        self._text = text
         self._text_field = text_field
-        self._num_results = num_results
+        self._text_scorer = text_scorer
+
         self.set_filter(filter_expression)
-        query_string = self._build_query_string()
-        from nltk.corpus import stopwords
-        import nltk
+        self._num_results = num_results
 
-        nltk.download('stopwords')
-        self._stopwords = set(stopwords.words('english'))
+        query_string = self._build_query_string()
 
-        super().__init__(query_string)
+        super().__init__(
+            query_string,
+            return_fields=return_fields,
+            num_results=num_results,
+            dialect=dialect,
+            sort_by=sort_by,
+            in_order=in_order,
+            params=params,
+        )
 
         # Handle query modifiers
-        if return_fields:
-            self.return_fields(*return_fields)
-
+        self.scorer(self._text_scorer)
         self.paging(0, self._num_results).dialect(dialect)
 
         if return_score:
-            self.return_fields(self.DISTANCE_ID) #TODO
-
-        if sort_by:
-            self.sort_by(sort_by)
-        else:
-            self.sort_by(self.DISTANCE_ID) #TODO
-
-        if in_order:
-            self.in_order()
+            self.with_scores()
 
-    
-    def _tokenize_query(self, user_query: str) -> str:
+    def tokenize_and_escape_query(self, user_query: str) -> str:
         """Convert a raw user query to a redis full text query joined by ORs"""
+        from redisvl.utils.token_escaper import TokenEscaper
 
-        words = word_tokenize(user_query)
-
-        tokens = [token.strip().strip(",").lower() for token in user_query.split()]
-        return " | ".join([token for token in tokens if token not in self._stopwords])
+        escaper = TokenEscaper()
 
+        tokens = [
+            escaper.escape(
+                token.strip().strip(",").replace("“", "").replace("”", "").lower()
+            )
+            for token in user_query.split()
+        ]
+        return " | ".join(
+            [token for token in tokens if token and token not in self._stopwords]
+        )
 
     def _build_query_string(self) -> str:
         """Build the full query string for text search with optional filtering."""
         filter_expression = self._filter_expression
-        # TODO include text only
         if isinstance(filter_expression, FilterExpression):
             filter_expression = str(filter_expression)
+        else:
+            filter_expression = ""
 
-        text = f"(~{Text(self._text_field) % self._tokenize_query(user_query)})"
-        
-        text_and_filter = text & self._filter_expression
-
-        #TODO is this method even needed? use 
-        return text_and_filter
+        text = f"(~@{self._text_field}:({self.tokenize_and_escape_query(self._text)}))"
+        if filter_expression and filter_expression != "*":
+            text += f"({filter_expression})"
+        return text
 
-# from redisvl.utils.token_escaper import TokenEscaper
-# escaper = TokenEscaper()
-# def tokenize_and_escape_query(user_query: str) -> str:
-#     """Convert a raw user query to a redis full text query joined by ORs"""
-#     tokens = [escaper.escape(token.strip().strip(",").replace("“", "").replace("”", "").lower()) for token in user_query.split()]
-#     return " | ".join([token for token in tokens if token and token not in stopwords_en])
 
-class HybridQuery(VectorQuery, TextQuery):
-    def __init__():
-        self,
-        text: str,
-        text_field: str,
-        vector: Union[List[float], bytes],
-        vector_field_name: str,
-        text_scorer: str = "TFIDF",
-        alpha: float = 0.7,
-        return_fields: Optional[List[str]] = None,
-        filter_expression: Optional[Union[str, FilterExpression]] = None,
-        dtype: str = "float32",
-        num_results: int = 10,
-        return_score: bool = True,
-        dialect: int = 2,
-        sort_by: Optional[str] = None,
-        in_order: bool = False,
+class HybridQuery(AggregateRequest):
+    def __init__(
+        self, text_query: TextQuery, vector_query: VectorQuery, alpha: float = 0.7
     ):
-        """A query for running a hybrid full text and vector search, along with
-        an optional filter expression.
+        """An aggregate query for running a hybrid full text and vector search.
 
         Args:
-            text (str): The text string to run text search with.
-            text_field (str): The name of the text field to search against.
-            vector (List[float]): The vector to perform the vector search with.
-            vector_field_name (str): The name of the vector field to search
-                against in the database.
-            text_scorer (str, optional): The text scoring algorithm to use.
-                Defaults to TFIDF.
+            text_query (TextQuery): The text query to run text search with.
+            vector_query (VectorQuery): The vector query to run vector search with.
             alpha (float, optional): The amount to weight the vector similarity
                 score relative to the text similarity score. Defaults to 0.7
-            return_fields (List[str]): The declared fields to return with search
-                results.
-            filter_expression (Union[str, FilterExpression], optional): A filter to apply
-                along with the vector search. Defaults to None.
-            dtype (str, optional): The dtype of the vector. Defaults to
-                "float32".
-            num_results (int, optional): The top k results to return from the
-                vector search. Defaults to 10.
-            return_score (bool, optional): Whether to return the vector
-                distance. Defaults to True.
-            dialect (int, optional): The RediSearch query dialect.
-                Defaults to 2.
-            sort_by (Optional[str]): The field to order the results by. Defaults
-                to None. Results will be ordered by vector distance.
-            in_order (bool): Requires the terms in the field to have
-                the same order as the terms in the query filter, regardless of
-                the offsets between them. Defaults to False.
-
-        Raises:
-            TypeError: If filter_expression is not of type redisvl.query.FilterExpression
-
-        Note:
-            Learn more about vector queries in Redis: https://redis.io/docs/interact/search-and-query/search/vectors/#knn-search
-        """
-        self._text = text
-        self._text_field_name = tex_field_name
-        self._vector = vector
-        self._vector_field_name = vector_field_name
-        self._dtype = dtype
-        self._num_results = num_results
-        self.set_filter(filter_expression)
-        query_string = self._build_query_string()
-        
-        # TODO how to handle multiple parents? call parent.__init__() manually?
-        super().__init__(query_string)
-
-        # Handle query modifiers
-        if return_fields:
-            self.return_fields(*return_fields)
-
-        self.paging(0, self._num_results).dialect(dialect)
 
-        if return_score:
-            self.return_fields(self.DISTANCE_ID)
-
-        if sort_by:
-            self.sort_by(sort_by)
-        else:
-            self.sort_by(self.DISTANCE_ID)
-
-        if in_order:
-            self.in_order()
-
-
-    def _build_query_string(self) -> str:
-        """Build the full query string for hybrid search with optional filtering."""
-        filter_expression = self._filter_expression
-        # TODO include hybrid
-        if isinstance(filter_expression, FilterExpression):
-            filter_expression = str(filter_expression)
-        return f"{filter_expression}=>[KNN {self._num_results} @{self._vector_field_name} ${self.VECTOR_PARAM} AS {self.DISTANCE_ID}]"
-
-    @property
-    def params(self) -> Dict[str, Any]:
-        """Return the parameters for the query.
-
-        Returns:
-            Dict[str, Any]: The parameters for the query.
         """
-        if isinstance(self._vector, bytes):
-            vector = self._vector
-        else:
-            vector = array_to_buffer(self._vector, dtype=self._dtype)
-
-        return {self.VECTOR_PARAM: vector}
-
+        pass

tests/unit/test_query_types.py

@@ -3,7 +3,14 @@
 from redis.commands.search.result import Result
 
 from redisvl.index.index import process_results
-from redisvl.query import CountQuery, FilterQuery, RangeQuery, VectorQuery
+from redisvl.query import (
+    CountQuery,
+    FilterQuery,
+    HybridQuery,
+    RangeQuery,
+    TextQuery,
+    VectorQuery,
+)
 from redisvl.query.filter import Tag
 
 # Sample data for testing
@@ -187,6 +194,69 @@ def test_range_query():
     assert range_query._in_order
 
 
+def test_text_query():
+    text_string = "the toon squad play basketball against a gang of aliens"
+    text_field_name = "description"
+    return_fields = ["title", "genre", "rating"]
+    text_query = TextQuery(
+        text=text_string,
+        text_field=text_field_name,
+        return_fields=return_fields,
+        return_score=False,
+    )
+
+    # Check properties
+    assert text_query._return_fields == return_fields
+    assert text_query._num_results == 10
+    assert (
+        text_query.filter
+        == f"(~@{text_field_name}:({text_query.tokenize_and_escape_query(text_string)}))"
+    )
+    assert isinstance(text_query, Query)
+    assert isinstance(text_query.query, Query)
+    assert isinstance(text_query.params, dict)
+    assert text_query._text_scorer == "BM25"
+    assert text_query.params == {}
+    assert text_query._dialect == 2
+    assert text_query._in_order == False
+
+    # Test paging functionality
+    text_query.paging(5, 7)
+    assert text_query._offset == 5
+    assert text_query._num == 7
+    assert text_query._num_results == 10
+
+    # Test sort_by functionality
+    filter_expression = Tag("genre") == "comedy"
+    scorer = "TFIDF"
+    text_query = TextQuery(
+        text_string,
+        text_field_name,
+        scorer,
+        filter_expression,
+        return_fields,
+        num_results=10,
+        sort_by="rating",
+    )
+    assert text_query._sortby is not None
+
+    # Test in_order functionality
+    text_query = TextQuery(
+        text_string,
+        text_field_name,
+        scorer,
+        filter_expression,
+        return_fields,
+        num_results=10,
+        in_order=True,
+    )
+    assert text_query._in_order
+
+
+def test_hybrid_query():
+    pass
+
+
 @pytest.mark.parametrize(
     "query",
     [