Rename for test data class for pytest conflict #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs333
commented
Mar 25, 2025
| # now run optimizer | ||
| router_optimizer = RouterThresholdOptimizer(router, test_data_optimization) | ||
| router_optimizer.optimize(max_iterations=10) | ||
| router_optimizer.optimize(max_iterations=10, search_step=0.5) |
Collaborator
Author
There was a problem hiding this comment.
Stop gap makes intermittent error damn near impossible. Also discovered helpful kwarg gap.
tylerhutcherson
changed the title
tylerhutcherson
approved these changes
Mar 25, 2025
Collaborator
tylerhutcherson
left a comment
tylerhutcherson
left a comment
There was a problem hiding this comment.
LGTM -- only question is where else would we need to update TestData (examples / docs?). But likely something we can do after release. Maybe create a ticket for that now though so we don't forget!
abrookins
pushed a commit
that referenced
this pull request
Apr 4, 2025
abrookins
pushed a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.