-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(core): deprecate useCustom result property for better type safety
#7110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alicanerdurmaz
wants to merge
3
commits into
main
Choose a base branch
from
fix/deprecate-use-custom-returned-result-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): deprecate useCustom result property for better type safety
#7110
alicanerdurmaz
wants to merge
3
commits into
main
from
fix/deprecate-use-custom-returned-result-value
+64
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `result.data` in favor of `query.data?.data` to fix type safety issues where empty objects during loading could cause runtime errors. - Add @deprecated JSDoc and warnOnce warning - Update docs and examples with migration guide - Maintain backward compatibility Resolves #7088
🦋 Changeset detectedLatest commit: e438b49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5 tasks
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
fix/deprecate-use-custom-returned-result-value
|
| Run status |
|
| Run duration | 19m 07s |
| Commit |
|
| Committer | Alican Erdurmaz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
22
|
|
|
0
|
|
|
378
|
| View all changes introduced in this branch ↗︎ | |
This comment was marked as spam.
This comment was marked as spam.
BatuhanW
approved these changes
Nov 14, 2025
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
useCustomhook returns aresult.dataproperty that always contains an empty object during loading states. This causes type safety issues where TypeScript cannot properly catch potential runtime errors when accessing nested properties.For example:
This is an undocumented breaking change that can lead to runtime errors.
What is the new behavior?
The
resultproperty is now deprecated with proper warnings and documentation:@deprecatedcomment to the type definition directing users to usequery.data?.dataRecommended usage:
This provides better type safety and aligns with TanStack Query patterns.
fixes #7088
Notes for reviewers
resultproperty is not removed, only deprecated - this maintains backward compatibility