Add sv_allowupload check on netchan validate
#788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wopox1337
changed the title
Contributor
|
@s1lentq |
|
@wopox1337 @s1lentq |
Collaborator
|
It's absolutelly incorrect place to fix your issue. |
Member
Author
|
@theAsmodai agree with you, but any suggestions? |
Contributor
|
but please, @theAsmodai don't close the issue and forget about it. We need a fix |
wopox1337
changed the title
sv_allowupload check on netchan validate
wopox1337
added
Engine: 📀 reHLDS
gmcsforce
added a commit
to gmcsforce/rehlds
that referenced
this pull request
Nov 4, 2021
CREDITS: wopox1337 PR: rehlds#788
s1lentq
force-pushed
the
master
branch
2 times, most recently
from
43df0ba to
de3679f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #787
This solution helps, but, the implementation is bad and I am looking for a better solution.
I haven't found a better solution yet, because the engine protocol can't tell the client to stop the download request.
P.S: I leave this PR open, as it solves the problem, albeit in a crutch way.
Download
6.oct.2020: rehlds - 3.7.0.701.zip(outdated)