react-router conflict between react-router-dom@5 and react-router-dom-v5-compat@6

[modi98]

I'm currently migrating an app from react-router v5 to v6 and I'm using react-router-dom-v5-compat for a step by step upgrade, but I keep getting errors from react-router-dom-v5-compat trying to reference [email protected], I'm assuming it's a conflict between the react-router-dom and react-router-dom-v5-compat versions I have installed.

My package.json looks like this:

{
  "dependencies": {
    "my-custom-client": "1.0.0",
    "react-router-dom": "5.3.4",
    "react-router-dom-v5-compat": "6.11.0"
  }
}

And the error looks like this:

WARNING in ./node_modules/react-router-dom-v5-compat/dist/index.js 1096:38-44
export 'Routes' (imported as 'Routes') was not found in 'react-router' (possible exports: MemoryRouter, Prompt, Redirect, Route, Router, StaticRouter, Switch, __HistoryContext, __RouterContext, generatePath, matchPath, useHistory, useLocation, useParams, useRouteMatch, withRouter)
 @ ./node_modules/my-custom-client/dist/index.js 18:13-36

Do note that I'm actually using both dependencies through another dependency, let's call it "my-custom-client", which has both libraries as peerDependencies, hence why the error is being thrown through that package on node_modules.

I've already tried adding "resolutions" to target the correct version of react-router for both dependencies but I still see the issue, I tried adding it like this:

"resolutions": {
  "react-router-dom/react-router": "5.3.4",
  "react-router-dom-v5-compat/react-router": "6.11.0"
}

Is there a known conflict between both dependencies being used on another dependency?

[modi98]

Closing this since I realized that it had to do with my webpack configuration, I had messed around with module resolution for the client bundle. I removed that and then this resolutions plus a clean install fixed the warning:

"resolutions": {
  "react-router-dom/react-router": "^5.3.4",
  "react-router-dom-v5-compat/react-router": "^6.11.0",
  "react-router-dom-v5-compat/history": "^5.0.0"
}