Skip to content

Conversation

@trombini77
Copy link

Context

This PR enhances the PHP-FPM healthcheck script by adding command-line options for FCGI connection parameters (--fcgi-connect and --fcgi-status-path), allowing more flexible configuration. It also updates the test suite, expands Makefile support for broader PHP versions (8.2-8.4) and distributions, and aligns the GitHub Actions CI workflow to match the Makefile's test matrix for consistency.

OBS: php container images based on Debian Buster and olders were removed because the OS packages are not more available (apt commad fail) like this:

2.975 Reading package lists...
2.988 W: The repository 'http://security.debian.org/debian-security stretch/updates Release' does not have a Release file.
2.988 W: The repository 'http://security.debian.org/debian-security buster/updates Release' does not have a Release file.
2.988 W: The repository 'http://deb.debian.org/debian stretch Release' does not have a Release file.
2.988 W: The repository 'http://deb.debian.org/debian stretch-updates Release' does not have a Release file.
2.988 W: The repository 'http://deb.debian.org/debian buster Release' does not have a Release file.
2.988 W: The repository 'http://deb.debian.org/debian buster-updates Release' does not have a Release file.
2.988 E: Failed to fetch http://security.debian.org/debian-security/dists/stretch/updates/main/binary-amd64/Packages  404  Not Found [IP: 151.101.66.132 80]
2.988 E: Failed to fetch http://security.debian.org/debian-security/dists/buster/updates/main/binary-amd64/Packages  404  Not Found [IP: 151.101.66.132 80]
2.988 E: Failed to fetch http://deb.debian.org/debian/dists/stretch/main/binary-amd64/Packages  404  Not Found [IP: 151.101.2.132 80]
2.988 E: Failed to fetch http://deb.debian.org/debian/dists/stretch-updates/main/binary-amd64/Packages  404  Not Found [IP: 151.101.2.132 80]
2.988 E: Failed to fetch http://deb.debian.org/debian/dists/buster/main/binary-amd64/Packages  404  Not Found [IP: 151.101.2.132 80]
2.988 E: Failed to fetch http://deb.debian.org/debian/dists/buster-updates/main/binary-amd64/Packages  404  Not Found [IP: 151.101.2.132 80]
2.988 E: Some index files failed to download. They have been ignored, or old ones used instead.
------
Dockerfile:4
--------------------
   3 |     # Required software
   4 | >>> RUN set -x \
   5 | >>>     && apt-get update \
   6 | >>>     && apt-get install -y libfcgi-bin
   7 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c set -x     && apt-get update     && apt-get install -y libfcgi-bin" did not complete successfully: exit code: 100
./test/docker.sh: line 12: CONTAINER: unbound variable
make: *** [Makefile:25: test-image] Error 1

Changes

  • Tests included (added new test cases in test_execution.py and verified with make qa)
  • Documentation updated (updated script help text and README if applicable)
  • Commit message is clear (atomic commits following https://cbea.ms/git-commit guidelines) Tests included
    Documentation updated
    Commit message is clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant