Skip to content

Commit f58c0b4

Browse files
authored
fix: w3m-header question mark icon is incorrectly rendered (#4982)
1 parent 75dfdbd commit f58c0b4

File tree

5 files changed

+47
-4
lines changed

5 files changed

+47
-4
lines changed

.changeset/slick-tigers-draw.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
'@reown/appkit-scaffold-ui': patch
3+
'pay-test-exchange': patch
4+
'@reown/appkit-adapter-bitcoin': patch
5+
'@reown/appkit-adapter-ethers': patch
6+
'@reown/appkit-adapter-ethers5': patch
7+
'@reown/appkit-adapter-solana': patch
8+
'@reown/appkit-adapter-wagmi': patch
9+
'@reown/appkit': patch
10+
'@reown/appkit-utils': patch
11+
'@reown/appkit-cdn': patch
12+
'@reown/appkit-cli': patch
13+
'@reown/appkit-codemod': patch
14+
'@reown/appkit-common': patch
15+
'@reown/appkit-controllers': patch
16+
'@reown/appkit-core': patch
17+
'@reown/appkit-experimental': patch
18+
'@reown/appkit-pay': patch
19+
'@reown/appkit-polyfills': patch
20+
'@reown/appkit-siwe': patch
21+
'@reown/appkit-siwx': patch
22+
'@reown/appkit-testing': patch
23+
'@reown/appkit-ui': patch
24+
'@reown/appkit-universal-connector': patch
25+
'@reown/appkit-wallet': patch
26+
'@reown/appkit-wallet-button': patch
27+
---
28+
29+
Fixed an issue where the question mark icon in the header was not displayed correctly

packages/scaffold-ui/src/partials/w3m-header/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
} from '@reown/appkit-controllers'
1616
import { customElement } from '@reown/appkit-ui'
1717
import '@reown/appkit-ui/wui-flex'
18-
import '@reown/appkit-ui/wui-icon-link'
18+
import '@reown/appkit-ui/wui-icon-button'
1919
import '@reown/appkit-ui/wui-select'
2020
import '@reown/appkit-ui/wui-tag'
2121
import '@reown/appkit-ui/wui-text'

packages/scaffold-ui/src/partials/w3m-header/styles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default css`
3333
animation-delay: 0ms, 200ms;
3434
}
3535
36-
wui-icon-link[data-hidden='true'] {
36+
wui-icon-button[data-hidden='true'] {
3737
opacity: 0 !important;
3838
pointer-events: none;
3939
}

packages/scaffold-ui/src/partials/w3m-wallet-send-details/index.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { LitElement, html } from 'lit'
2-
import { property } from 'lit/decorators.js'
2+
import { property, state } from 'lit/decorators.js'
33
import { ifDefined } from 'lit/directives/if-defined.js'
44

55
import { type CaipNetwork } from '@reown/appkit-common'
@@ -20,6 +20,8 @@ export class W3mWalletSendDetails extends LitElement {
2020

2121
@property({ type: Object }) public caipNetwork?: CaipNetwork
2222

23+
@state() private params = RouterController.state.data?.send
24+
2325
// -- Render -------------------------------------------- //
2426
public override render() {
2527
return html` <wui-text variant="sm-regular" color="secondary">Details</wui-text>
@@ -53,7 +55,7 @@ export class W3mWalletSendDetails extends LitElement {
5355
}
5456

5557
private onNetworkClick(network?: CaipNetwork) {
56-
if (network) {
58+
if (network && !this.params) {
5759
RouterController.push('Networks', { network })
5860
}
5961
}

packages/scaffold-ui/test/partials/w3m-header.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,18 @@ describe('W3mHeader', () => {
232232

233233
expect(trackSpy).toHaveBeenCalledWith({ type: 'track', event: 'CLICK_WALLET_HELP' })
234234
})
235+
236+
it('should hide help button when not in Connect view', async () => {
237+
RouterController.state.view = 'Account'
238+
OptionsController.state.enableNetworkSwitch = false
239+
element.requestUpdate()
240+
await element.updateComplete
241+
await elementUpdated(element)
242+
243+
const helpButton = element.shadowRoot?.querySelector('wui-icon-button[icon="helpCircle"]')
244+
expect(helpButton).toBeTruthy()
245+
expect(helpButton?.getAttribute('data-hidden')).toBe('true')
246+
})
235247
})
236248

237249
describe('Network Selector Visibility', () => {

0 commit comments

Comments
 (0)