Skip to content

DO NOT MERGE feat: fix SA version to 6 #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE feat: fix SA version to 6 #5309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/appkit/exports/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const PACKAGE_VERSION = '1.8.11'
export const PACKAGE_VERSION = '1.8.12'
1 change: 1 addition & 0 deletions packages/wallet/src/W3mFrame.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ function createSecureSiteSdkUrl({
url.searchParams.set('version', SECURE_SITE_SDK_VERSION)
url.searchParams.set('enableLogger', String(enableLogger))
url.searchParams.set('rpcUrl', rpcUrl)
url.searchParams.set('smartAccountVersion', 'v6')
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smartAccountVersion value 'v6' is hardcoded. Consider making this configurable through the W3mFrameConfig interface to allow flexibility for future version changes or different deployment scenarios. This would improve maintainability and avoid requiring code changes when the smart account version needs to be updated.

Copilot uses AI. Check for mistakes.
if (enableCloudAuthAccount) {
url.searchParams.set('enableCloudAuthAccount', 'true')
}
Expand Down
Loading