Skip to content

repoze.retry does not work with repoze.tm2-2.0b1 #2

@stephan-hof

Description

@stephan-hof

Sorry for abusing the github Issues, but I did not find a way to post on
http://bugs.repoze.org

With this change in repoze.tm2 repoze/repoze.tm2@4b68c7d
a pipeline with repoze.retry -> rempoze.tm2 does not work anymore.
repoze.retry raises a 'app must call start_response before returning' assertion.

The reason is that repoze.retry gets from repoze.tm2 a 'generator' object. The code within this generator, which is the whole logic of tm2, is not executed up to this point. The code within a generator is executed the first time iteration starts.
So 'start_response' is definitively not called.

I'm not sure if its a repoze.tm2 or repoze.retry problem.
I mean repoze.tm2 can be rewritten to call 'start_response' and still support streaming.
On the other side repoze.retry can be changed as well, to support retrying if a generator is returned.

I can work on this issue, but need a bit guidance for the way to go.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions