Merge pull request #1387 from Axionize/fix/lp-vector-3

booky10 · web-flow · commit 7ba541843bcd · 2025-10-30T23:05:56.000+01:00
Fix incorrect encoding of LPVector3d
diff --git a/api/src/main/java/com/github/retrooper/packetevents/protocol/util/LpVector3d.java b/api/src/main/java/com/github/retrooper/packetevents/protocol/util/LpVector3d.java
@@ -67,7 +67,7 @@ public static void write(PacketWrapper<?> wrapper, Vector3d vector) {
         }
         long maxLong = MathUtil.ceilLong(max);
         boolean large = (maxLong & 0b11L) != maxLong;
-        long mul = large ? ((maxLong % 0b11L) | 0b100L) : maxLong;
+        long mul = large ? ((maxLong & 0b11L) | 0b100L) : maxLong;
         long packedX = pack(x / (double) maxLong) << 3;
         long packedY = pack(y / (double) maxLong) << 18;
         long packedZ = pack(z / (double) maxLong) << 33;

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public static void write(PacketWrapper<?> wrapper, Vector3d vector) {`
`67`	`67`	`}`
`68`	`68`	`long maxLong = MathUtil.ceilLong(max);`
`69`	`69`	`boolean large = (maxLong & 0b11L) != maxLong;`
`70`		`- long mul = large ? ((maxLong % 0b11L) \| 0b100L) : maxLong;`
	`70`	`+ long mul = large ? ((maxLong & 0b11L) \| 0b100L) : maxLong;`
`71`	`71`	`long packedX = pack(x / (double) maxLong) << 3;`
`72`	`72`	`long packedY = pack(y / (double) maxLong) << 18;`
`73`	`73`	`long packedZ = pack(z / (double) maxLong) << 33;`