Fixed IndexOutOfBoundsException for ClientPlayerDigging, ClientClientStatus, and ClientInteractEntity #1371
+35
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoJokeFNA
reviewed
Oct 9, 2025
|
|
||
| package com.github.retrooper.packetevents.protocol.player; | ||
|
|
||
| public enum InteractAction { |
There was a problem hiding this comment.
We now have the class 2 times, no?
https://github.com/retrooper/packetevents/pull/1371/files#diff-ea1bb08a8407de704db4ba3657b251d706d8cc19d1ad124504fd33e4fd6c5ef6R168
…layer/InteractAction.java Removed as it was useless
NoJokeFNA
suggested changes
Oct 27, 2025
| import com.github.retrooper.packetevents.manager.server.ServerVersion; | ||
| import com.github.retrooper.packetevents.netty.buffer.ByteBufHelper; | ||
| import com.github.retrooper.packetevents.netty.buffer.ByteBufInputStream; | ||
| import com.github.retrooper.packetevents.netty.buffer.ByteBufOperator; |
There was a problem hiding this comment.
I don’t get why these imports need to be in this class.
Why did you touch this class at all? Nothing’s really been added.
Also, your TODO comment should probably be an issue instead.
Removed TODO comment regarding byte buffer handling for malformed packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.