Skip to content

Conversation

@linsaftw
Copy link
Contributor

@linsaftw linsaftw commented Oct 27, 2025

This fixes compatibility with VeloFlame and any other anti-bots or forks running before packet events.

@booky10 booky10 merged commit efeb901 into retrooper:2.0 Oct 27, 2025
2 checks passed
@AoElite
Copy link
Contributor

AoElite commented Nov 2, 2025

@linsaftw @booky10 Was this PR tested to ensure PacketEvents actually works after this change?

@Axionize
Copy link
Contributor

Axionize commented Nov 2, 2025

Thanks for bringing this to my attention @FlorianMichael.

@linsaftw is there any reason why instead of having a handler in the Netty pipeline at the front you're pushing this broken change down on every project in the Minecraft space?

This doesn't fix any "other anti-bots or forks" running before packetevents. This only "fixes" VeloFlame.

@booky10 did you test this before merging...?

@linsaftw
Copy link
Contributor Author

linsaftw commented Nov 2, 2025

Thanks for bringing this to my attention @FlorianMichael.

@linsaftw is there any reason why instead of having a handler in the Netty pipeline at the front you're pushing this broken change down on every project in the Minecraft space?

This doesn't fix any "other anti-bots or forks" running before packetevents. This only "fixes" VeloFlame.

@booky10 did you test this before merging...?

Hi guys, sorry for making this mistake. It had to go after the initChannel method call instead. Thank you so much guys for pointing out the issue and making a pr to fix.

@Axionize
Copy link
Contributor

Axionize commented Nov 2, 2025

coming-to-your-senses

Stop making volunteers on open source projects like ViaVersion and PacketEvents clean up after your code so you can sell more copies of your broken software.

You've on multiple occasions pushed maintainers to write changes to fix an issue you describe claiming you couldn't make a PR because "Gradle ran too slow on your computer" to build. Your users have flooded into the PacketEvents Discord and complaining about issues caused by your products that you didn't fix for months and now this shit.

This PR is particularly egregious - you claimed it fixed "any other anti-bots or forks" when it only fixed VeloFlame, your paid product. You didn't even test if PacketEvents still worked after your change.

Throwing broken untested code onto open source projects to workaround issues with your code and making it everyone else's problem is not acceptable.

I have no compunctions against and even support you monetizing your work to support yourself but I do have a problem when you make your work my problem. Stop making your commercial problems everyone else's unpaid work.

@linsaftw
Copy link
Contributor Author

linsaftw commented Nov 2, 2025

coming-to-your-senses

Stop making volunteers on open source projects like ViaVersion and PacketEvents clean up after your code so you can sell more copies of your broken software.

You've on multiple occasions pushed maintainers to write changes to fix an issue you describe claiming you couldn't make a PR because "Gradle ran too slow on your computer" to build. Your users have flooded into the PacketEvents Discord and complaining about issues caused by your products that you didn't fix for months and now this shit.

This PR is particularly egregious - you claimed it fixed "any other anti-bots or forks" when it only fixed VeloFlame, your paid product. You didn't even test if PacketEvents still worked after your change.

Throwing broken untested code onto open source projects to workaround issues with your code and making it everyone else's problem is not acceptable.

I have no compunctions against and even support you monetizing your work to support yourself but I do have a problem when you make your work my problem. Stop making your commercial problems everyone else's unpaid work.

You are absolutely right and I will make sure to take extra time to test everything. VeloFlame itself is not paid and I really just want the people satisfied with patches very fast. As a self-critic, I consider I have to pay more attention to devs themselves.

In terms of money, look, in the case of VeloFlame, it's free, whats paid are some extra quirks, I just want to make stuff to fix people's problems while it becomes my work, I am sorry to sometimes bring weird patches, and I try to make up useful patches when possible too. I really do make a lot of mistakes, and I dont like playing the disability card but I am really disabled and diagnosed and it's one of the main reasons I make mistakes so even if I don't like saying it, it's directly related to my mistakes.

During the day I try to bring as much fixes and patches to my projects and to other projects, this is not a hobbie for me and I am through very harsh conditions due to the lack of economic opportunities, I really try to be as helpful as possible, not to development exactly, but to the people using it, and I will send a personal apology to booky because you guys are 100% right and I made a mistake and he trusted me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants