diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a8369b9..fa6ef395 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,1041 +1,6 @@ # Change Log -## 2.16.0 and above - -For changes in version 2.16 and above, the change log has moved to this repo's [GitHub Releases Page](https://github.com/rollbar/rollbar-gem/releases) - -## 2.15.6 -- Update rollbar.js snippet to `v2.3.8` [#680](https://github.com/rollbar/rollbar-gem/issues/680) -- Update `delayed_job` dependency to `4.1.3` [#672](https://github.com/rollbar/rollbar-gem/issues/672) -- Add rollbar.js snippet on all responses regardless of status code [#664](https://github.com/rollbar/rollbar-gem/issues/664) -- Add documentation for `sinatra/namespace` vs `rake` conflict to `README.md` [#663](https://github.com/rollbar/rollbar-gem/issues/663) -- Add `aws-sdk-sqs` gem dependency [#659](https://github.com/rollbar/rollbar-gem/issues/659) -- Upgrade `rails` gem dependency to `4.2.7.1` [#656](https://github.com/rollbar/rollbar-gem/issues/656) -- Add documentation note for usage of `Rollbar.scope!` to `README.md` [#653](https://github.com/rollbar/rollbar-gem/issues/653) -- Add example of using `Grape` to deal with `500` responses status [#645](https://github.com/rollbar/rollbar-gem/issues/645) -- Always report errors from `delayed_job` to deal with `dj_threshold > 0` edge case [#615](https://github.com/rollbar/rollbar-gem/issues/615) -- Fix "Empty message" items for exceptions reported from JRuby [#658] - -## 2.15.5 - -- Support proxies [#626](https://github.com/rollbar/rollbar-gem/pull/626) - -## 2.15.4 - -- Fix bug related to dup'ing extra passed in data - -## 2.15.3 - -- Fix a bug when host is nil when we are trying to extract data about a request - [#637](https://github.com/rollbar/rollbar-gem/pull/637). -- Make a copy of extra data passed in so we don't modify frozen objects - [#638](https://github.com/rollbar/rollbar-gem/pull/638) - -## 2.15.2 - -- Fix how person data is injected into javascript - -## 2.15.1 - -- Update rollbar.js to v2.2.3 [#630](https://github.com/rollbar/rollbar-gem/pull/630) -- allow csp opt out [#629](https://github.com/rollbar/rollbar-gem/pull/629) -- Fix: [#472](https://github.com/rollbar/rollbar-gem/issues/472) -- Ignore empty ROLLBAR_ENV [#604](https://github.com/rollbar/rollbar-gem/pull/604) -- Shoryuken gem support [#576](https://github.com/rollbar/rollbar-gem/pull/576) -- support new sidekiq context structure [#598](https://github.com/rollbar/rollbar-gem/pull/598) - -## 2.15.0 - -Features: - -- Support person data in rollbar.js. See [#602](https://github.com/rollbar/rollbar-gem/pull/602). -- Update rollbar.js to v2.0.4. See [#600](https://github.com/rollbar/rollbar-gem/pull/600). -- Add Configuration#use_exception_level_filters option. See [#588](https://github.com/rollbar/rollbar-gem/pull/588). - -Fixes: - -- get session from env instead of request. See [#586](https://github.com/rollbar/rollbar-gem/pull/586). -- If multiple forwarded hosts are present in the headers, use the first. See [#582](https://github.com/rollbar/rollbar-gem/pull/582). -- Replace present? call with plain ruby alternative. See [#579](https://github.com/rollbar/rollbar-gem/pull/579). - -Others: -- Codacy cleanup. See [#599](https://github.com/rollbar/rollbar-gem/pull/599). -- Remove warning on @root_notifier cause not initialized. See [#562](https://github.com/rollbar/rollbar-gem/pull/562). -- [Docs] I think you mean this. See [#596](https://github.com/rollbar/rollbar-gem/pull/596). -- Fix syntax error in code example. See [#581](https://github.com/rollbar/rollbar-gem/pull/581). - - -## 2.14.1 - -- Add host as a configuration options. See [#560](https://github.com/rollbar/rollbar-gem/pull/560). -- Scrub all values based on matched keys set in the configuration rather than only string values. - See [#567](https://github.com/rollbar/rollbar-gem/pull/567). -- Allow for a specification of the name of the queue for delayed_job. See - [#574](https://github.com/rollbar/rollbar-gem/pull/574). - -## 2.14.0 - -Features: - -- Add Rollbar::Middleware::Rack. See [#558](https://github.com/rollbar/rollbar-gem/pull/558). -- Send request body on DELETE request. See [#555](https://github.com/rollbar/rollbar-gem/pull/555). - -Fixes: - -- Fix validations plugin on Rails 5.0 with belong_to.See [#556](https://github.com/rollbar/rollbar-gem/pull/556). -- Remove few warnings when using minitest with rollbar installed. See [#557](https://github.com/rollbar/rollbar-gem/pull/557). -- Fix tests 1.9. See [#554](https://github.com/rollbar/rollbar-gem/pull/554). - -Others: - -- Updating readme. See [#552](https://github.com/rollbar/rollbar-gem/pull/552). -- Removed doctoc tag. See [#550](https://github.com/rollbar/rollbar-gem/pull/550). -- Adding info about Sidekiq and ActiveJob. See [#548](https://github.com/rollbar/rollbar-gem/pull/548). -- Fix wrong version number in Readme. See [#535](https://github.com/rollbar/rollbar-gem/pull/535). - -## 2.13.3 - -- Fix undefined variable name in rollbar.js middleware. See [#537](https://github.com/rollbar/rollbar-gem/pull/537). - -## 2.13.2 - -Fixes: - -- Fix URL scrubbing with spaces in the query. See [#532](https://github.com/rollbar/rollbar-gem/pull/532). -- Use :use_exception_level_filters in ActiveJob plugin. See [#533](https://github.com/rollbar/rollbar-gem/pull/533). - -Other: - -- Add docs for custom scrubbing with transform hook. See [#526](https://github.com/rollbar/rollbar-gem/pull/526). - -## 2.13.1 - -Fixes: - -- Inherit test controller from ActionController::Base -- Fix test rake task when Rack::MockRequest is not defined -- Fix docs for Sinatra middleware -- Fix few basic rubocop offenses - -## 2.13.0 - -Features: -- Allow to override config. See [#519](https://github.com/rollbar/rollbar-gem/pull/519). -- Send code and context frame data. See [#523](https://github.com/rollbar/rollbar-gem/pull/523). -- Send GET, POST and raw body in their correct place. See [#522](https://github.com/rollbar/rollbar-gem/pull/522). -- Increase max payload from 128kb to 512kb. See [#521](https://github.com/rollbar/rollbar-gem/pull/521). -- Add resque-rollbar functionality to the gem. See [#516](https://github.com/rollbar/rollbar-gem/pull/516). -- Send custom.orig_host and custom.orig_uuid on too large payloads. See [#518](https://github.com/rollbar/rollbar-gem/pull/518). -- Add Content-Length and Content-Type headers to the reports. See [#513](https://github.com/rollbar/rollbar-gem/pull/513). - -Bug fixes: -- SecureHeaders fixes. See [#478](https://github.com/rollbar/rollbar-gem/pull/478). -- Include validations plugin in activerecord base. See [#503](https://github.com/rollbar/rollbar-gem/pull/503). -- Require tempfile and use ::Tempfile. See [#514](https://github.com/rollbar/rollbar-gem/pull/514). -- Extract correct client IP from X-Forwarded-For header. See [#515](https://github.com/rollbar/rollbar-gem/pull/515). -- Delayed job fix on job serialization. See [#512](https://github.com/rollbar/rollbar-gem/pull/512). - -Others: -- Fix tests on rails40 and ruby 1.8.7. See [#485](https://github.com/rollbar/rollbar-gem/pull/485). -- Move log methods to public section. See [#498](https://github.com/rollbar/rollbar-gem/pull/498). -- Change rails50.gemfile to use Rails 5.0.0. See [#495](https://github.com/rollbar/rollbar-gem/pull/495). -- Update CHANGELOG.md to fix incorrect links. See [#502](https://github.com/rollbar/rollbar-gem/pull/502). -- Improve Rake support to avoid conflicts with other services. See [#517](https://github.com/rollbar/rollbar-gem/pull/517). -- Make Codeclimate happier with Rollbar::Middlware::Js. See [#520](https://github.com/rollbar/rollbar-gem/pull/520). - - -## 2.12.0 - -Features: - -- Scrub sidekiq params if needed -- Prepare rake task for non Rails frameworks - -Others: -- Typo on README.md -- Add documentation for plugins architecture in docs/plugins.md - -## 2.11.5 - -Bugf ixes: - -- Use require_dependency for rake and sidekiq plugins. See [#485](https://github.com/rollbar/rollbar-gem/pull/485). -- Add immediate ActiveModel::Validations monkey patch. See [#484](https://github.com/rollbar/rollbar-gem/pull/484). -- Pass correct options to Item.build_with. See [#480](https://github.com/rollbar/rollbar-gem/pull/480). - -Documentation: - -- Update exception filter heading and TOC. See [#481](https://github.com/rollbar/rollbar-gem/pull/481). -- Add advanced usage of exception filters in readme. See [#477](https://github.com/rollbar/rollbar-gem/pull/477). - - -## 2.11.4 - -Change: - -- Update rollbar.js snippet - -## 2.11.3 - -Fix: - -- Don't rely on #as_json for delayed_job payload_object. See [#463](https://github.com/rollbar/rollbar-gem/pull/463). - -## 2.11.2 - -Fix: - -- Fix active_model require in validations plugin. See [#461](https://github.com/rollbar/rollbar-gem/pull/461). - -## 2.11.1 - -Bug fixes: - -- Don't return inside a Proc object in rollbar.js plugin. See [#458](https://github.com/rollbar/rollbar-gem/pull/458). - -## 2.11.0 - -New features: - -- Rollbar.js support with SecureHeaders 2.0. See [#448](https://github.com/rollbar/rollbar-gem/pull/448). -- Inject extensions in ActiveModel::Validations instead of ActiveRecord::Base. See [#445](https://github.com/rollbar/rollbar-gem/pull/445). - -Bug fixes: - -- Fix URL scrubbing and change to a functional object. See [#454](https://github.com/rollbar/rollbar-gem/pull/454). -- Allow any argument for BasicSocket#as_json. See [#455](https://github.com/rollbar/rollbar-gem/pull/455). -- Retry request on network timeouts. See [#453](https://github.com/rollbar/rollbar-gem/pull/453). - -Refactors and others: - -- Refactor Item payload building. See [#452](https://github.com/rollbar/rollbar-gem/pull/452). -- Mock the requests to Rollbar API. See [#450](https://github.com/rollbar/rollbar-gem/pull/450). -- Add plugins architecture. See [#438](https://github.com/rollbar/rollbar-gem/pull/438). -- Add TOC for README.md. See [#444](https://github.com/rollbar/rollbar-gem/pull/444). - -## 2.10.0 - -New features: - -- Set the Sidekiq error context to the worker class name. See [#440](https://github.com/rollbar/rollbar-gem/pull/440). -- Secure headers support for rollbar.js integration. See [#437](https://github.com/rollbar/rollbar-gem/pull/437). -- Rails 5 support. See [#433](https://github.com/rollbar/rollbar-gem/pull/433). -- Add scrub all parameters option. See [#431](https://github.com/rollbar/rollbar-gem/pull/431). -- Add delayed_job async handler. See [#430](https://github.com/rollbar/rollbar-gem/pull/430). -- Disable logging if Rollbar is disabled. See [#425](https://github.com/rollbar/rollbar-gem/pull/425). - -Bug fixes: - -- Add nil check for rake.patch! for future robustness. See [#434](https://github.com/rollbar/rollbar-gem/pull/434). -- Fix two doc bugs. See [#401](https://github.com/rollbar/rollbar-gem/pull/401). - -## 2.9.1 - -Bug fixes: - -- Fix Sidekiq support for version > 3.x. Thanks @phlipper. See [#423](https://github.com/rollbar/rollbar-gem/pull/423). - -## 2.9.0 - -Bug fixes: - -- Clean scope before every Sidekiq job execution. See [#421](https://github.com/rollbar/rollbar-gem/pull/421). -- Threads reaper. See [#418](https://github.com/rollbar/rollbar-gem/pull/418). - -New features: -- Rollbar logger. See [#417](https://github.com/rollbar/rollbar-gem/pull/417). - -Others: -- Fix dependencies. See [#402](https://github.com/rollbar/rollbar-gem/pull/402). -- Use mime-types < 3.0 for RUBY < 2.0. See [#420](https://github.com/rollbar/rollbar-gem/pull/420). -- Add .codeclimate.yml. See [#409](https://github.com/rollbar/rollbar-gem/pull/409). -- Use SimpleCov with CodeClimate formatter. See [#408](https://github.com/rollbar/rollbar-gem/pull/408). -- Setup CodeClimate coverage. See [#407](https://github.com/rollbar/rollbar-gem/pull/407). -- Typo in the transform hook documentation. See [#406](https://github.com/rollbar/rollbar-gem/pull/406). - - -## 2.8.3 - -Bug fixes: - -- Fix rake_version method. See [#397](https://github.com/rollbar/rollbar-gem/pull/397). -- Fix rake development version to < 11. See [#400](https://github.com/rollbar/rollbar-gem/pull/400). - -## 2.8.2 - -Bug fixes: - -- Rollbar JavaScript: Make lookup stricter to avoid matching
. See [#394](https://github.com/rollbar/rollbar-gem/pull/394) -- Fix encoding problem when scrubing parameters. See [#395](https://github.com/rollbar/rollbar-gem/pull/395) - -## 2.8.1 - -New features: - -- Fix support for SuckerPunch v2. See [#393](https://github.com/rollbar/rollbar-gem/pull/393) - -## 2.8.0 - -New features: - -- Add before_process and transform hooks. See [#375](https://github.com/rollbar/rollbar-gem/pull/375) -- Rollbar.js instrumentation. See [#382](https://github.com/rollbar/rollbar-gem/pull/382) -- Add `disable_rack_monkey_patch` configuration option. See [#377](https://github.com/rollbar/rollbar-gem/pull/377) -- Add Rubocop config. See [#379](https://github.com/rollbar/rollbar-gem/pull/379) - -Bug fixes: - -- Notify deploy only on primary `:rollbar_role` server. See [#368](https://github.com/rollbar/rollbar-gem/pull/368) -- Fix `Rollbar::Notifier#report_custom_data_error`. See [#376](https://github.com/rollbar/rollbar-gem/pull/376) -- Reset the notifier when we use `Rollbar.preconfigure`. See [#378](https://github.com/rollbar/rollbar-gem/pull/378) -- Fix sucker_punch tests. See [#372](https://github.com/rollbar/rollbar-gem/pull/372) - -Docs: - -- Add link from README to configuration. See [#383](https://github.com/rollbar/rollbar-gem/pull/383) -- Add rough draft of configuration options documentation. See [#373](https://github.com/rollbar/rollbar-gem/pull/373) -- Add plain ruby docs. See [#374](https://github.com/rollbar/rollbar-gem/pull/374) -- Document exception level filters. See [#366](https://github.com/rollbar/rollbar-gem/pull/366) -- Fix typo in README.md Sending backtrace without rescued exceptions. See [#364](https://github.com/rollbar/rollbar-gem/pull/364) - - -## 2.7.1 - -- Suggest using ROLLBAR_ENV for staging apps. See [#353](https://github.com/rollbar/rollbar-gem/pull/353). -- Fix Rollbar::Util.deep_merge so it has default values for arguments. See [#362](https://github.com/rollbar/rollbar-gem/pull/362). -- Ignore exception cause when it's not another exception. See [#357](https://github.com/rollbar/rollbar-gem/pull/357). - - -## 2.7.0 - -- Delayed job integration fix. See [#355](https://github.com/rollbar/rollbar-gem/pull/355). - - Delayed job support limited to versions >= 3.0 -- Better diagnostic when failsafe is on. See [#354](https://github.com/rollbar/rollbar-gem/pull/354). -- Document Language/Framework Support. See [#352](https://github.com/rollbar/rollbar-gem/pull/352). - -## 2.6.3 - -Change: - -- Add default scrub fields, "api_key" and "access_token". See [#348](https://github.com/rollbar/rollbar-gem/pull/348). - - -## 2.6.2 - -Bug fix: - -- Fix crash when sidekik job has `retry` key but not `retry_count`. See [#346](https://github.com/rollbar/rollbar-gem/pull/346). - -## 2.6.1 - -Bug fix: - -- Don't skip delayed_job reports if attempts > dj_threshold. See [#340](https://github.com/rollbar/rollbar-gem/pull/340). - -## 2.6.0 - -Features - -- Sidekiq threshold for retried jobs. Allows you define a minimum number of retries to start reporting errors to Rollbar. See [#336](https://github.com/rollbar/rollbar-gem/pull/336). -- User IP obfuscator. See [#331](https://github.com/rollbar/rollbar-gem/pull/331) and [#338](https://github.com/rollbar/rollbar-gem/pull/338). - -## 2.5.2 - -Bug fixes: - -- Use ACCEPT header to check json requests. See [#333](https://github.com/rollbar/rollbar-gem/pull/333) -- Fix URL scrubbing when using a malformed URL. See [#332](https://github.com/rollbar/rollbar-gem/pull/332) - -## 2.5.1 - -Bug fix: - -- Fix Rollbar::JSON for MultiJson <= 1.6.0. See [#328](https://github.com/rollbar/rollbar-gem/pull/328) - -## 2.5.0 - -Features: - -- URL scrubbing for Ruby > 1.8.7. See [#323](https://github.com/rollbar/rollbar-gem/pull/323) and [#235](https://github.com/rollbar/rollbar-gem/pull/325) - -Bug fixes: - -- Fix Rollbar::JSON so it resolves the correct options module. See [#321](https://github.com/rollbar/rollbar-gem/pull/321) -- Fix SSL verify mode. See [#320](https://github.com/rollbar/rollbar-gem/pull/320) and [#326](https://github.com/rollbar/rollbar-gem/pull/326) - -## 2.4.0 - -Features: - -- Allow custom revision name on capistrano integration. See [#312](https://github.com/rollbar/rollbar-gem/pull/312) - -Internal changes: - -- Restore MultiJson and add custom option modules. Fix #303. See [#304](https://github.com/rollbar/rollbar-gem/pull/304) -- Don't require rollbar/rails on initializer. See [#310](https://github.com/rollbar/rollbar-gem/pull/310) -- Fix delayed_job tests for delayed_job >= 4.1. See [#309](https://github.com/rollbar/rollbar-gem/pull/309) - -Documentation: - -- Change README.md and template to use 'default' Sidekiq queue. See [#306](https://github.com/rollbar/rollbar-gem/pull/306) - -Bug fixes: - -- Remove better errors hook. This was causing to report twice the errors. See [#313](https://github.com/rollbar/rollbar-gem/pull/313) - - -## 2.3.0 - -Internal changes: - -- Use Oj instead of JSON gem for payload serializing. See [#300](https://github.com/rollbar/rollbar-gem/pull/300) -- Send nearest backtrace entry on failsafe messages. See [#290](https://github.com/rollbar/rollbar-gem/pull/290) -- Remove whitespace from config template. See [#295](https://github.com/rollbar/rollbar-gem/pull/295) - -Bug fixes: - -- Send correct hash value for delayed job 'handler' object. See [#301](https://github.com/rollbar/rollbar-gem/pull/301) -- Fix delayed_job crash reports. See [#293](https://github.com/rollbar/rollbar-gem/pull/293) -- Send session data instead of session store options. [#289](https://github.com/rollbar/rollbar-gem/pull/289) - - -## 2.2.1 - -Improvement: - -- Speed-up payload encoding. See [#285](https://github.com/rollbar/rollbar-gem/pull/285) - -## 2.2.0 - -New features: - -- Raise internal exceptions when processing reports from async handlers, instead of swallowing them. This allows queue systems (e.g. Sidekiq, Resque) to track and retry errored jobs. See [#282](https://github.com/rollbar/rollbar-gem/pull/282) -- Send the error class name when reporting internal errors. See [#283](https://github.com/rollbar/rollbar-gem/pull/283) - -## 2.1.2 - -Bug fix: - -- Allow having multiple uploads for the same parameter. Thanks @mdominiak. - -## 2.1.1 - -Bug fix: - -- Don't swallow exceptions on `Rollbar::ActiveJob` module. With this fix we don't break the ActiveJob backends' features like retries. - -## 2.1.0 - -New feature: - -- If you use `ActiveJob`, you can now include the `Rollbar::ActiveJob` module into your ActiveJob classes. Then, errors happening in your jobs will be automatically reported to Rollbar. - -## 2.0.2 - -Bug fixes: - -- Fix capistrano task cause a namespace conflict between JSON and Rollbar::JSON. - -## 2.0.1 - -Bug fixes: - -- Remove requires for multi_json gem. Thanks @albertyw. - -## 2.0.0 - -Possibly breaking changes: - -- If active_support version < 4.1.0 is installed, this gem will now monkeypatch `BasicSocket#to_json`. This is needed to work around a bug causing JSON serialization to fail when the payload contains a Socket instance. We don't expect this to break anything for anyone, unless you are using active_support version < 4.1.0 and also happened to be relying on the buggy Socket serialization behavior. - -Bug fixes: - -- Use the JSON gem or native by default. Along with the aforementioned monkeypatch, this fixes the existing bug in active_support < 4.1.0 serializing Socket instances. To disable the monkeypatch, set `config.disable_core_monkey_patch = true`. -- Add Encoding module, with Encoder and LegacyEncoder classes. This fixes some issues with ISO-8859 strings - -Other changes: - -- Update README.md and warn about upgrade to capistrano >= 3.1 -- Fix error in code example for custom Async handlers - -## 1.5.3 - -Bug fixes: - -- Run `rollbar-rails-runner` in the context of `Rails` module so we avoid namespace conflicts. See [#242](https://github.com/rollbar/rollbar-gem/pull/242) - -## 1.5.2 - -Bug fixes: - -- Fix minimum body truncation strategy when the payload is a message without exception. See [#240](https://github.com/rollbar/rollbar-gem/pull/240) - -## 1.5.1 - -Bug fixes: - -- Fixed crashes when `Configuration#custom_data_method` fails. Now a report for that crash will be reported also. See [#235](https://github.com/rollbar/rollbar-gem/pull/235) - -## 1.5.0 - -Bug fixes: - -- Fixed support for extended unicode characters. See [#234](https://github.com/rollbar/rollbar-gem/pull/234) - -Possible breaking changes: - -- Some characters that previously were stripped are now encoded. This could cause some events to be grouped into new items by Rollbar. - - -## 1.4.5 - -Bug fixes: - -- Fixed internal error reporting IpSpoofAttackErrors. See [#233](https://github.com/rollbar/rollbar-gem/pull/233) -- Removed duplicated `schedule_payload` definition. See [#231](https://github.com/rollbar/rollbar-gem/pull/231) - - -## 1.4.4 - -New features: - -- Added configuration option to gather backtraces for exceptions that don't already have one (i.e. if you do `Rollbar.error(Exception.new)`). Set `config.populate_empty_backtraces = true` to enable it. See [#206](https://github.com/rollbar/rollbar-gem/pull/206) - -Bug fixes: - -- Reverted capistrano change as it causes problems in some setups. See [#210](https://github.com/rollbar/rollbar-gem/pull/210) - -Other: - -- Refactored the Sidekiq handler (no changes to the interface). See [#197](https://github.com/rollbar/rollbar-gem/pull/197) - -## 1.4.3 - -New features: - -- The current thread's scope can now be modified using `Rollbar.scope!`. This can be used to provide context data which will be included if the current request/job/etc. later throws an exception. See [#212](https://github.com/rollbar/rollbar-gem/pull/212) - -Bug fixes: - -- Remove duplicate `#configure` definition. See [#207](https://github.com/rollbar/rollbar-gem/pull/207) -- In the capistrano task, don't override set variables. See [#210](https://github.com/rollbar/rollbar-gem/pull/210) -- Style fix in sidekiq handler. See [#209](https://github.com/rollbar/rollbar-gem/pull/209) - -## 1.4.2 - -Bug fixes: - -- Fix null 'context' in internal error reports. See [#208](https://github.com/rollbar/rollbar-gem/pull/208) - -## 1.4.1 - -Bug fixes: - -- Fix internal error when ActiveRecord was present, but not used. See [#204](https://github.com/rollbar/rollbar-gem/pull/204) - -## 1.4.0 - -Possible breaking changes: - -- `exception_level_filters` is now applied only to "uncaught" errors (i.e. those detected by middlewares) but not to direct calls to `Rollbar.error`. If you were previously using `Rollbar.error` (or `Rollbar.warning`, etc.), the new behavior is *probably* desirable, but if it isn't, you can get the old behavior via `Rollbar.error(e, :use_exception_level_filters => true)`. The middlewares that ship with the gem also now pass this new flag. - -## 1.3.2 - -Bug fixes: - -- Fix bug with the `write_to_file` method where values were dumped as ruby hashes instead of json. See [#198](https://github.com/rollbar/rollbar-gem/pull/198) - -## 1.3.1 - -Bug fixes: - -- Fix bug with smart truncation for messages. See [#195](https://github.com/rollbar/rollbar-gem/issues/195) and [#196](https://github.com/rollbar/rollbar-gem/issues/196) -- Safely catch exceptions in `process_payload` when called from an async handler. See [#196](https://github.com/rollbar/rollbar-gem/pull/196) - - -## 1.3.0 - -Performance improvements: - -- In the Rails, Rack, and Sinatra middlewares, request data is now gathered only when needed instead of in advance on every request. See [#194](https://github.com/rollbar/rollbar-gem/pull/194); fixes [#180](https://github.com/rollbar/rollbar-gem/issues/180) - -Possible breaking changes: - -- If the scope's `:request` or `:context` value is an object that responds to `:call`, those values will now be called when a a report is made (and their result will be used in the payload). This is very unlikely to affect anyone, but we're releasing this as a version bump just to be safe. - - -## 1.2.13 - -New features: - -- Person tracking for Rack/Sinatra apps. See [#192](https://github.com/rollbar/rollbar-gem/pull/192) - -Bug fixes: - -- Fix `rollbar:test` rake task (regression from 1.2.12); see [985c091](https://github.com/vyrak/rollbar-gem/commit/985c091ad58ae4f4c6997dd356497b4e5a2be498) - -## 1.2.12 - -Bug fixes: - -- Fix bug introduced in 1.2.11 that broke the sidekiq async handler. See [#190](https://github.com/rollbar/rollbar-gem/issues/190) -- Skip Rake monkeypatch for Rake < 0.9.0. Fixes [#187](https://github.com/rollbar/rollbar-gem/issues/187) - - -## 1.2.11 - -New features: - -- Improved truncation algorithm, so that more kinds of large payloads will be successfully brought below the 128kb limit and successfully reported. See [#185](https://github.com/rollbar/rollbar-gem/pull/185) - -Bug fixes: - -- Fix issue where using Rollbar outside of a web process was prone to errors being silently ignored. See [#183](https://github.com/rollbar/rollbar-gem/issues/183) - - -## 1.2.10 - -Bug fixes: - -- Fix bug introduced in 1.2.8 with Sidekiq version < 3. See [#181](https://github.com/rollbar/rollbar-gem/issues/181) - - -## 1.2.9 - -Bug fixes: - -- Fix issue causing request and person data to not be collected for RoutingErrors. See [#178](https://github.com/rollbar/rollbar-gem/pull/178) - - -## 1.2.8 - -New features: - -- Add config option to not monkeypatch `Rack::Builder`. See [#169](https://github.com/rollbar/rollbar-gem/pull/169) -- Track server PID. See [#171](https://github.com/rollbar/rollbar-gem/pull/171) - - -Bug fixes: - -- Remove internal calls to deprecated methods. See [#166](https://github.com/rollbar/rollbar-gem/pull/166) -- Fix an intermittently failing test. See [#167](https://github.com/rollbar/rollbar-gem/pull/167) -- Fix configuration issue when an initializer calls `Thread.new` before Rollbar is initialized. See [#170](https://github.com/rollbar/rollbar-gem/pull/170) and [#168](https://github.com/rollbar/rollbar-gem/pull/168) -- Fix infinite loop with cyclic inner exceptions. See [#172](https://github.com/rollbar/rollbar-gem/pull/172) - - -## 1.2.7 - -Bug fixes: -- Restore `exception_level_filters` feature, which was inadvertently removed in 1.2.0. See [#160](https://github.com/rollbar/rollbar-gem/pull/160) -- Fix bug where rollbar_url incorrectly handled comma-separated X-Forwarded-Proto header values. See [#112](https://github.com/rollbar/rollbar-gem/issues/112) - - -## 1.2.6 - -Bug fixes: - -- Fix bug in non-Rails environments. See [#155](https://github.com/rollbar/rollbar-gem/pull/155) -- Fix intermittent test failures - - -## 1.2.5 - -Bug fixes: - -- Fix issues handling hashes, arrays, and other values as the raw POST body. See [#153](https://github.com/rollbar/rollbar-gem/pull/153) - - -## 1.2.4 - -Bug fixes: - -- Fix issue where requiring 'rack' unnecessarily broke things in non-rack apps. See [#150](https://github.com/rollbar/rollbar-gem/pull/150) - - -## 1.2.3 - -Bug fixes: - -- Bring back `enforce_valid_utf8`, which got lost in the 1.2.0 upgrade. See [#148](https://github.com/rollbar/rollbar-gem/pull/148) -- Fix bug with raw post extraction for application/json requests. See [#147](https://github.com/rollbar/rollbar-gem/pull/147) - - -## 1.2.2 - -Bug fixes: - -- Fix issue with delayed_job and Rollbar.report_exception (bug introduced in 1.2.0). See [#145](https://github.com/rollbar/rollbar-gem/issues/145) -- Explicitly require 'rack' in request_data_extractor. See [#144](https://github.com/rollbar/rollbar-gem/pull/144) - - -## 1.2.1 - -Bug fixes: - -- Revert change made as part of 1.2.0 where all procs in the payload would be evaluated. See [#143](https://github.com/rollbar/rollbar-gem/pull/143). - - -## 1.2.0 - -New features: - -- Added new, much nicer interface for sending exceptions and messages to Rollbar. This is a backwards-compatible release: the old interface (`report_message`, `report_exception`, `report_message_with_request`) is deprecated but will continue to work at least until 2.0. - - See the docs for [basic](https://github.com/rollbar/rollbar-gem#caught-exceptions-and-messages) and [advanced](https://github.com/rollbar/rollbar-gem#advanced-usage) usage for a guide to the new interface. If you've used [rollbar.js](https://github.com/rollbar/rollbar.js), it will be familiar. - ---- - -## 1.1.0 - -New features: - -- Support nested exceptions for Ruby 2.1. See [#136](https://github.com/rollbar/rollbar-gem/pull/136). NOTE: for exceptions that have causes, this will change how they are grouped in Rollbar. If you have custom grouping rules, they will need to be updated to replace `body.trace.exception` with `body.trace_chain[0].exception` to maintain the same behavior for these exceptions. -- New feature: `failover_handlers`. You can specify a list of async handlers, which will be tried in sequence upon failure. See [#135](https://github.com/rollbar/rollbar-gem/pull/135). - -Bug fixes: - -- Fix handling of utf8 sequences in payload symbols. See [#131](https://github.com/rollbar/rollbar-gem/pull/131). Thanks [@kroky](https://github.com/kroky) for the fix and [@jondeandres](https://github.com/jondeandres) for reviewing. -- Fix logic bugs in assignments for `scrub_fields` and `scrub_headers`. See [#137](https://github.com/rollbar/rollbar-gem/pull/137) - ---- - -## 1.0.1 - -Bug fixes: - -- Use the payload's access token for the X-Rollbar-Access-Token header, instead of the configured access token. Fixes an issue where payloads would be reported into the wrong project when sent via Resque. See [#128](https://github.com/rollbar/rollbar-gem/pull/128). Thanks to [@jondeandres](https://github.com/jondeandres) for the fix. - -## 1.0.0 - -Bug fixes: - -- Strip out invalid UTF-8 characters from payload keys/values, fixes [#85](https://github.com/rollbar/rollbar-gem/issues/85) - - -Misc: - -- Clean up some unused requires -- Bumping to 1.0 due to the suggestion in [#119](https://github.com/rollbar/rollbar-gem/issues/119) - ---- - -## 0.13.2 - -- Sidekiq payload is no longer mutated when Rollbar reports a Sidekiq job exception -- Fix sucker_punch async reporting when using a forking application server such as Unicorn (`preload_app true`). Jobs are now instantiated for every report instead of a reused global job instance - - -## 0.13.1 -- Silence warning when using project_gems= with regexp [#120](https://github.com/rollbar/rollbar-gem/pull/120) - - -## 0.13.0 - -- Hook for delayed_job no longer a plugin, will now only ever be initialized once -- New configuration option `delayed_job_enabled` that defaults to true -- Potentially breaking change if using delayed_job: if you disabled the delayed_job plugin previously, please remove that code and instead set the new configuration option `delayed_job_enabled` to false - - -## 0.12.20 -- Fix asynchronous reports with sidekiq version < 2.3.2 -- Support for specifying multiple project_gems with regex [#114](https://github.com/rollbar/rollbar-gem/pull/114) - -## 0.12.19 -- Fix rake test task in production -- Report an additional simple error message in the rake test task - -## 0.12.18 -- Insert RollbarRequestStore middleware at the end in case the ActiveRecord ConnectionManagement middleware isn't used -- Scope Capistrano 3 task by server role [#110](https://github.com/rollbar/rollbar-gem/pull/110) - -## 0.12.17 -- Replace usage of `puts` with a configurable logger in different areas of the notifier -- Fix error in `RollbarRequestStore` when `rollbar_person_data` isn't defined for a controller - -## 0.12.16 -- Scrub fields are now converted to a regular expression for broader param name matching -- Save ActionDispatch request_id in reports if present -- Added proper Sidekiq 3 error handler -- Removed usage of ActiveSupport's `Object#try` in different areas of the notifier -- Added a configurable request timeout for reports (defaults to 3 seconds) -- Fix circular json exception handling in Rails 4.1 - -## 0.12.15 -- Send X-Rollbar-Access-Token http header along with payloads - -## 0.12.14 -- Added ability to scrub request headers -- Added flag to disable reporting of Delayed::Job job data when handling uncaught exceptions that happen in jobs -- New `report_message_with_request` that allows reporting request and person data, similar to `report_exception` -- Changed various exception handlers to catch `Exception` subclasses instead of only `StandardError`s -- Added Capistrano 3 support - -## 0.12.13 -- Add a little more debugging information for 'payload too large' errors -- Pushing new gem to fix errant 32kb size limit in the rubygems copy of 0.12.12 - -## 0.12.12 -- Changes to support Engine Yard add-on setup - -## 0.12.11 -- Raise payload size limit to 128k - -## 0.12.10 -- Log payloads that are too large to be sent to Rollbar -- Don't record controller context if request route info isn't readily available (ex. non-Rails) - -## 0.12.9 -- Fixed delayed job regression introduced in 0.12.5 by re-raising caught exceptions -- Removed Active Support call introduced in 0.12.6 to remove rails dependency in `report_exception` - -## 0.12.8 -- Added funcitonality to walk the payload and truncate strings to attempt to reduce size if the payload is too large (more than 32kb total) - -## 0.12.7 -- Fix error reporting errors when route controller or action is nil (bug introduced in 0.12.4) - -## 0.12.6 -- Added [#78](https://github.com/rollbar/rollbar-gem/pull/78), added configuration option to ignore specific person exceptions - -## 0.12.5 -- Fixed SIGSEGV with the delayed_job plugin and Ruby 2.1.0 - -## 0.12.4 -- Record controller context (controller#action) in reported items - -## 0.12.3 -- Change rollbar_request_store middleware to only grab required person data properties by using rollbar_person_data - -## 0.12.2 -- Added ability to specify level for manually reported exceptions - -## 0.12.1 -- Fix syntax error in `config.use_sidekiq` usage example - -## 0.12.0 -- Added [#73](https://github.com/rollbar/rollbar-gem/pull/73), enhanced Sidekiq and SuckerPunch configuration. NOTE: The old `Rollbar::Configuration#use_sidekiq=` and `Rollbar::Configuration#use_sucker_punch=` methods are now deprecated, see the docs for updated usage information. - -## 0.11.8 -- Make sure the person method exists for the controller before trying to extract person data - -## 0.11.7 -- Remove ActiveRecord railtie requirement introduced in 0.11.6 - -## 0.11.6 -- Adding new middleware that grabs possible database-hitting person data before the rake connection pool cleanup middleware - -## 0.11.5 -- Fix rake test task when Authlogic is present - -## 0.11.4 -- Respect different proxy headers when building the request url - -## 0.11.3 -- Make sure the environment is valid at item sending time so that it isn't set incorrectly during configuration - -## 0.11.2 -- Test rake task now works properly if force_ssl is true - -## 0.11.1 -- `config.exception_level_filters` can now take a callable instead of a string. The exception instance will be passed to the callable. - -## 0.11.0 -- Changed default environment name from `'production'` to `'unspecified'` - -## 0.10.14 -- Fixed compatability issue with better_errors 1.0 - -## 0.10.13 -- Added `code_version` configuration setting - -## 0.10.12 -- Exclude HTTP_COOKIE header (since cookies are already included in parsed form) - -## 0.10.11 -- Fix usage of custom Sidekiq options - -## 0.10.10 -- Add support for sucker_punch asynchronous handling - -## 0.10.9 -- Fix regression introduced in 0.10.7 when ActiveRecord is not present. - -## 0.10.8 -- Better handling of internal errors. Internal errors (errors that occur while reporting something to Rollbar) are now themselves reported to Rollbar. If that fails, a failsafe message will be reported, and if that fails, the error will be logged as it is now. -- Fix bug reporting exceptions with backtraces containing frames that don't match our regex. - -## 0.10.7 -- Add ability to report form validation errors -- Add MIT license to gemspec - -## 0.10.6 -- Fix json dump when rack.errors is an IO stream - -## 0.10.5 -- Add built-in support for Sidekiq as async handler - -## 0.10.4 -- Fix exception in the exception catcher when Rollbar is disabled - -## 0.10.3 -- Rework how request params are extracted so that json params are properly extracted in rails 4.0 -- Fix rollbar:test rake task - -## 0.10.2 -- Require hooks at configuration time instead of gem load time - -## 0.10.1 -- Fix regression in 0.10.0 reporting exceptions in development environments and rails < 3.2 apps. - -## 0.10.0 -- Fixed bug causing duplicate reports when used inside Rails in production with the default error pages. Bumping version to 0.10.0 in case this turns out to be backwards-incompatible for some use cases (i.e. for applications that were relying on the duplicate report that has now been removed). - -## 0.9.14 -- Added `custom_data_method` config option. If set, it should be a lambda that returns a hash. -- Changed initializer template to disable reporting from the 'test' environment. - -## 0.9.13 -- Add test for PUT params -- Parse json params when content-type is application/json -- Fix concurrency issue -- Remove redundant `GET` and `POST` keys from request payload (they're already included in `params`) - -## 0.9.12 -- Fix compatibility issue with Rails 4 / Ruby 2 (thanks [johnknott](https://github.com/johnknott)) - -## 0.9.11 -- Provide a default environment name when used outside of Rails and none is set - -## 0.9.10 -- Add :secret_token to default scrub_fields list -- Session params are now scrubbed - -## 0.9.9 -- Fix capistrano recipe on 1.9.2 ([#36](https://github.com/rollbar/rollbar-gem/pull/36)) -- Add example of disable "test" env to initializer template - -## 0.9.8 -- Fix bug introduced in 0.9.0 where setting `config.enabled = false` in `config/initializers/rollbar.rb` would be overwritten by subsequent calls to `Rollbar.configure` (as happens normally when using inside Rails). - -## 0.9.7 -- Use `include?` instead of `in?` for filtering (see [#34](https://github.com/rollbar/rollbar-gem/pull/34)) - -## 0.9.6 -- Fix for Rails 4 support - -## 0.9.5 -- Support for configuring the access token with an environment variable. - -## 0.9.4 -- Fixed issue using rollbar-gem outside of Rails -- Clarified the "details: " link log message - -## 0.9.3 -- Added configuration setting to specify gems that should be considered part of the Rollbar project, making frames from these gems show up automatically uncollapsed in tracebacks appearing on the website. - -## 0.9.2 -- Added [Capistrano integration](https://github.com/rollbar/rollbar-gem/pull/27) - -## 0.9.1 -- Add support to play nicely with Better Errors. - -## 0.9.0 -- Behavior change: start configuration as `@enabled = false`, and set to true when `configure` is called. This addresses an issue using Rollbar without the environment initialized. Such reports would always fail (since there would be no access token), but now they won't be attempted. - -## 0.8.3 -- Relax multi_json dependency to 1.5.0 - -## 0.8.2 -- Adding back rake task exception reporting after fixing load order issue - -## 0.8.1 -- Reverting rake task exception reporting until we can track down a load order issue reported by a few users - -## 0.8.0 -- Rename to rollbar - -## 0.7.1 -- Fix ratchetio:test rake task when project base controller is not called ApplicationController - -## 0.7.0 -- Exceptions in Rake tasks are now automatically reported. - -## 0.6.4 -- Bump multi_json dependency version to 1.6.0 - -## 0.6.3 -- Bump multi_json dependency version to 1.5.1 - -## 0.6.2 -- Added EventMachine support - -## 0.6.1 -- Added a log message containing a link to the instance. Copy-paste the link into your browser to view its details in Ratchet. -- Ratchetio.report_message now returns 'ignored' or 'error' instead of nil when a message is not reported for one of those reasons, for consistency with Ratchetio.report_exception. - -## 0.6.0 -- POSSIBLE BREAKING CHANGE: Ratchetio.report_exception now returns 'ignored', 'disabled', or 'error' instead of nil when the exception is not reported for one of those reasons. It still returns the payload upon success. -- Request data is now parsed from the rack environment instead of from within the controller, addressing issue #10. -- Add Sidekiq middleware for catching workers' exceptions -- Replaced activesupport dependency with multi_json - -## 0.5.5 -- Added activesupport dependency for use without Rails - -## 0.5.4 -- Added new default scrub params - -## 0.5.3 -- Add `Ratchetio.silenced`; which allows disabling reporting for a given block. See README for usage. - -## 0.5.2 -- Fix compat issue with delayed_job below version 3. Exceptions raised by delayed_job below version 3 will not be automatically caught; upgrade to v3 or catch and report by hand. - -## 0.5.1 -- Save the exception uuid in `env['ratchetio.exception_uuid']` for display in user-facing error pages. - -## 0.5.0 -- Add support to report exceptions raised in delayed_job. - -## 0.4.11 -- Allow exceptions with no backtrace (e.g. StandardError subclasses) - -## 0.4.10 -- Fix compatability issue with ruby 1.8 - -## 0.4.9 -- Start including a UUID in reported exceptions -- Fix issue with scrub_fields, and add `:password_confirmation` to the default list - -## 0.4.8 -- Add ability to send reports asynchronously, using girl_friday or Threading by default. -- Add ability to save reports to a file (for use with ratchet-agent) instead of sending across to Ratchet servers. - -## 0.4.7 -- Sensitive params now scrubbed out of requests. Param name list is customizable via the `scrub_fields` config option. - -## 0.4.6 -- Add support to play nicely with Goalie. - -## 0.4.5 -- Add `default_logger` config option. It should be a lambda that will return the logger to use if no other logger is configured (i.e. no logger is set by the Railtie hook). Default: `lambda { Logger.new(STDERR) }` - -## 0.4.4 -- Add `enabled` runtime config flag. When `false`, no data (messages or exceptions) will be reported. - -## 0.4.3 -- Add RSpec test suite. A few minor code changes. - -## 0.4.2 -- Add "ignore" filter level to completely ignore exceptions by class. - -## 0.4.1 -- Recursively filter files out of the params hash. Thanks to [trisweb](https://github.com/trisweb) for the pull request. - -## 0.4.0 - -- Breaking change to make the "person" more configurable. If you were previously relying on your `current_member` method being called to return the person object, you will need to add the following line to `config/initializers/ratchetio.rb`: - - config.person_method = "current_member" - -- Person id, username, and email method names are now configurable -- see README for details. +## 1.0 +- Initial implementation +- Codebase was forked from v3.6.0 of original Rollbar gem. +- Functionality added to log messages to application log before sending them to the Rollbar API. \ No newline at end of file diff --git a/README.md b/README.md index af9ea251..b0dd1ba2 100644 --- a/README.md +++ b/README.md @@ -1,79 +1,13 @@ -

- rollbar-logo -

+This is a forked version of https://github.com/rollbar/rollbar-gem. -

Rollbar Ruby Gem

+## High Level Summary +This forked implementation allows the `Rollbar` module to send messages to Datadog as well as Rollbar (assuming Datadog has been set up in the application). -

- Proactively discover, predict, and resolve errors in real-time with Rollbar’s error monitoring platform. Start tracking errors today! -

+## Detailed Changes +The class `Notifier` in the original gem contains two methods that directly reference the Rollbar API to which messages are sent: +* `#send_using_eventmachine` +* `#send_body` +These two methods are overridden in this forked gem in order to inject code to add messages to the application log. Assuming Datadog has been set up in the application, the Datadog agent should be tailing the application log in order to send the logged messages to Datadog. This, in effect, allows messages sent via the `Rollbar` module to be sent to Datadog as well as to Rollbar. -![Build Status](https://github.com/rollbar/rollbar-gem/workflows/Rollbar-gem%20CI/badge.svg?tag=latest) -[![Gem Version](https://badge.fury.io/rb/rollbar.svg)](http://badge.fury.io/rb/rollbar) -[![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&target-version=latest)](https://dependabot.com/compatibility-score.html?dependency-name=rollbar&package-manager=bundler&version-scheme=semver&new-version=latest) - - ---- - -[Rollbar](https://rollbar.com) is a real-time exception reporting service for Ruby and other languages. The Rollbar service will alert you of problems with your code and help you understand them in a ways never possible before. We love it and we hope you will too. - -Rollbar-gem is the SDK for Ruby apps and includes support for apps using Rails, Sinatra, Rack, plain Ruby, and other frameworks. - - -## Key benefits of using Rollbar Ruby Gem are: - -- **Frameworks:** Rollbar Ruby Gem supports popular Ruby frameworks such as Rails, Sinatra, Grape and more. -- **Integrations:** Rollbar Ruby has integrations for Resque, ActiveJob, rollbar-agent, Sidekiq and more! -- **Automatic error grouping:** Rollbar aggregates Occurrences caused by the same error into Items that represent application issues. Learn more about reducing log noise. -- **Advanced search:** Filter items by many different properties. Learn more about search. -- **Customizable notifications:** Rollbar supports several messaging and incident management tools where your team can get notified about errors and important events by real-time alerts. Learn more about Rollbar notifications. - - -## Setup Instructions - -1. [Sign up for a Rollbar account](https://rollbar.com/signup) -2. Follow the [Getting Started](https://docs.rollbar.com/docs/ruby#section-getting-started) instructions in our [Ruby SDK docs](https://docs.rollbar.com/docs/ruby) to install rollbar-gem and configure it for your platform. - -## Usage and Reference - -For complete usage instructions and configuration reference, see our [Ruby SDK docs](https://docs.rollbar.com/docs/ruby). - -## Compatibility - -Version >= 3.0.0 is compatible with Ruby >= 2.0.0. - -Version >= 2.19.0 is compatible with Ruby >= 1.9.3. - -Version < 2.19.0 is compatible with Ruby >= 1.8.7. - -### Ruby 2.6.0 - -> WARNING: Ruby 2.6.0 introduced a new bug ([#15472 - -Invalid JSON data being sent from Net::HTTP in some cases with Ruby 2.6.0](https://bugs.ruby-lang.org/issues/15472)) that may result in the Rollbar API returning an error when an exception is reported. (See [rollbar-gem issue #797](https://github.com/rollbar/rollbar-gem/issues/797)). - -> UPDATE: This bug is fixed in Ruby 2.6.1, and rollbar-gem has a safe workaround in version >= 2.19.0. -If you need to stay on Ruby 2.6.0 for any reason, make sure you have the latest rollbar-gem. - -## Release History & Changelog - -See our [Releases](https://github.com/rollbar/rollbar-gem/releases) page for a list of all releases, including changes. - -## Help / Support - -If you run into any issues, please email us at [support@rollbar.com](mailto:support@rollbar.com) - -For bug reports, please [open an issue on GitHub](https://github.com/rollbar/rollbar-gem/issues/new). - -## Contributing - -1. Fork it -2. Create your feature branch (```git checkout -b my-new-feature```). -3. Commit your changes (```git commit -am 'Added some feature'```) -4. Push to the branch (```git push origin my-new-feature```) -5. Create new Pull Request - -We're using RSpec for testing. Run the test suite with ```rake spec```. Tests for pull requests are appreciated but not required. (If you don't include a test, we'll write one before merging.) - -## License -Rollbar-gem is free software released under the MIT License. See [LICENSE](LICENSE) for details. +The exception to this is the handling of uncaught exceptions. Datadog should already be set up to log uncaught exceptions in the application, so it would not be necessary to also add those messages to the application log for the Datadog agent to pick up. diff --git a/lib/rollbar.rb b/lib/rollbar.rb index 7c1da783..53855897 100644 --- a/lib/rollbar.rb +++ b/lib/rollbar.rb @@ -17,7 +17,7 @@ require 'rollbar/logger_proxy' require 'rollbar/exceptions' require 'rollbar/lazy_store' -require 'rollbar/notifier' +require 'rollbar/logger_notifier' # The Rollbar module. It stores a Rollbar::Notifier per thread and # provides some module methods in order to use the current thread notifier. @@ -37,7 +37,7 @@ class << self def notifier # Use the global instance @root_notifier so we don't fall # in a infinite loop - Thread.current[:_rollbar_notifier] ||= Notifier.new(@root_notifier) + Thread.current[:_rollbar_notifier] ||= LoggerNotifier.new(@root_notifier) #Forked update: use overridden logger class end def notifier=(notifier) diff --git a/lib/rollbar/exception_reporter.rb b/lib/rollbar/exception_reporter.rb index 18b334f3..b4c8ef34 100644 --- a/lib/rollbar/exception_reporter.rb +++ b/lib/rollbar/exception_reporter.rb @@ -39,7 +39,7 @@ def log_exception_message(exception) def exception_data(exception) Rollbar.log(Rollbar.configuration.uncaught_exception_level, exception, - :use_exception_level_filters => true) + :use_exception_level_filters => true, :uncaught_error => true) #Forked update: add indicator for uncaught exceptions end end end diff --git a/lib/rollbar/logger_notifier.rb b/lib/rollbar/logger_notifier.rb new file mode 100644 index 00000000..50b8236f --- /dev/null +++ b/lib/rollbar/logger_notifier.rb @@ -0,0 +1,67 @@ +require "rollbar/notifier" +require "json" + +# This overrides the Notifier in the original rollbar-gem. +# +# It overrides two methods: +# 1. #send_using_eventmachine(body) +# 2. #send_body(body) +# These two methods are the last methods called before messages are sent to the Rollbar server. +# +# The override allows for the injection of code that sends messages to the application log +# before sending the messages to the Rollbar server. +# +module Rollbar + class LoggerNotifier < Notifier + # This is an override of a method in the original rollbar-gem. + def send_using_eventmachine(body) + begin + format_and_log(body) + rescue => e + ::Rails.logger.error("Error in Rollbar::LoggerNotifier#send_using_eventmachine: #{e.message}") + ensure + super(body) + end + end + + # This is an override of a method in the original rollbar-gem. + def send_body(body) + begin + format_and_log(body) + rescue => e + ::Rails.logger.error("Error in Rollbar::LoggerNotifier#send_body: #{e.message}") + ensure + super(body) + end + end + + # This method takes the messages meant to be sent to Rollbar's server and logs them to the application log, + # where the Datadog agent will pick up the messages and send them to Datadog. + def format_and_log(body) + body_hash = ::JSON.parse(body) + + # Skip logging to application logger for Datadog to pick up. Datadog is already configured to log uncaught errors directly. + return if body_hash.dig("data", "body", "trace", "extra", "uncaught_error") + return if body_hash.dig("data", "body", "message", "extra", "uncaught_error") + + level = body_hash.dig("data", "level") + method_name = :error + + # Rollbar levels: https://github.com/rollbar/rollbar-gem/blob/f9d0be72a8048a5e8ae54200c84a5dff2fe513fb/lib/rollbar/logger.rb#L67-L69 + case level + when "debug" + method_name = :debug + when "info" + method_name = :info + when "warning" + method_name = :warn + when "error" + method_name = :error + when "critical" + method_name = :fatal + end + + ::Rails.logger.send(method_name, body) + end + end +end \ No newline at end of file