[CMake] Move to CMake's native FindGTest

- Remove own FindGTest, use the one from CMake.
  Starting from CMake 3.23, the GTest libraries have canonical names.
- Replace uses of legacy targets like "gtest" in ROOT with canonical
  target names such as GTest::gtest or GTest::gtest_main.
- Same as above for roottest.
- For CMake between 3.20 and 3.23, create ALIAS targets with the same
  names as in 3.23 (e.g. GTest::gtest_main).
  For CMake < 3.23, this will allow using the standard FindGTest with
  the modern names already in cmake 3.20.
- Explicitly list GTest::gmock as a dependency in core.

Author: hageboeck

cmake/modules/FindGTest.cmake

@@ -1808,13 +1808,10 @@ function(ROOT_ADD_GTEST test_suite)
   # against. For example, tests in Core should link only against libCore. This could be tricky
   # to implement because some ROOT components create more than one library.
   ROOT_EXECUTABLE(${test_suite} ${source_files} LIBRARIES ${ARG_LIBRARIES})
-  target_link_libraries(${test_suite} PRIVATE gtest gtest_main gmock gmock_main)
+  target_link_libraries(${test_suite} PRIVATE GTest::gtest GTest::gmock GTest::gtest_main GTest::gmock_main)
   if(TARGET ROOT::TestSupport)
     target_link_libraries(${test_suite} PRIVATE ROOT::TestSupport)
   else()
-    # Since we don't inherit the linkage against gtest from ROOT::TestSupport,
-    # we need to link against gtest here.
-    target_link_libraries(${test_suite} gtest)
     message(WARNING "ROOT_ADD_GTEST(${test_suite} ...): The target ROOT::TestSupport is missing. It looks like the test is declared against a ROOT build that is configured with -Dtesting=OFF.
             If this test sends warning or error messages, this will go unnoticed.")
   endif()

cmake/modules/RootMacros.cmake

@@ -2022,6 +2022,15 @@ if (builtin_gtest)
 
 endif()
 
+# Starting from cmake 3.23, the GTest targets will have stable names.
+# ROOT was updated to use those, but for older CMake versions, we have to declare the aliases:
+foreach(LIBNAME gtest_main gmock_main gtest gmock)
+  if(NOT TARGET GTest::${LIBNAME} AND TARGET ${LIBNAME})
+    add_library(GTest::${LIBNAME} ALIAS ${LIBNAME})
+  endif()
+endforeach()
+
+#------------------------------------------------------------------------------------
 if(webgui AND NOT builtin_openui5)
   ROOT_CHECK_CONNECTION("builtin_openui5=ON")
   if(NO_CONNECTION)

cmake/modules/SearchInstalledSoftware.cmake

@@ -8,7 +8,7 @@ ROOT_ADD_GTEST(testMake_unique testMake_unique.cxx LIBRARIES Core)
 ROOT_ADD_GTEST(testTypeTraits testTypeTraits.cxx LIBRARIES Core)
 ROOT_ADD_GTEST(testNotFn testNotFn.cxx LIBRARIES Core)
 ROOT_ADD_GTEST(testClassEdit testClassEdit.cxx  LIBRARIES Core RIO COPY_TO_BUILDDIR ${CMAKE_CURRENT_SOURCE_DIR}/file_16199.C)
-ROOT_ADD_GTEST(testException testException.cxx LIBRARIES Core)
+ROOT_ADD_GTEST(testException testException.cxx LIBRARIES Core GTest::gmock)
 ROOT_ADD_GTEST(testLogger testLogger.cxx LIBRARIES Core)
 ROOT_ADD_GTEST(testRRangeCast testRRangeCast.cxx LIBRARIES Core)
 ROOT_ADD_GTEST(testStringUtils testStringUtils.cxx LIBRARIES Core)

core/foundation/test/CMakeLists.txt

@@ -26,6 +26,7 @@ ROOT_ADD_GTEST(
 
   LIBRARIES
   Core
+  GTest::gmock
 )
 
 add_dependencies(TClingTest Cling RIO)

core/metacling/test/CMakeLists.txt

@@ -16,7 +16,7 @@ target_include_directories(${libname} PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/inc/>
   $<INSTALL_INTERFACE:./>
   )
-target_link_libraries(${libname} PUBLIC Core gtest)
+target_link_libraries(${libname} PRIVATE Core GTest::gtest)
 
 # Installation of header and library:
 set_target_properties(${libname} PROPERTIES PUBLIC_HEADER inc/${header_dir}/TestSupport.hxx)

core/testsupport/CMakeLists.txt

@@ -10,7 +10,7 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL Intel)
 endif()
 
 add_library(VectorisedPDFTests STATIC VectorisedPDFTests.cxx)
-target_link_libraries(VectorisedPDFTests PUBLIC gtest ROOT::Gpad ROOT::RooFitCore ROOT::RooFit)
+target_link_libraries(VectorisedPDFTests PUBLIC ROOT::Gpad ROOT::RooFitCore ROOT::RooFit GTest::gtest)
 
 ROOT_ADD_GTEST(testCompatMode testCompatMode.cxx
               LIBRARIES VectorisedPDFTests)

roofit/roofit/test/vectorisedPDFs/CMakeLists.txt

@@ -1154,8 +1154,7 @@ function(ROOTTEST_ADD_UNITTEST_DIR)
   endif()
 
   add_executable(${binary} ${unittests_SRC})
-  target_include_directories(${binary} PRIVATE ${GTEST_INCLUDE_DIR})
-  target_link_libraries(${binary} gtest gtest_main ${libraries})
+  target_link_libraries(${binary} PRIVATE GTest::gtest GTest::gtest_main ${libraries})
 
   if(MSVC AND DEFINED ROOT_SOURCE_DIR)
     if(TARGET ROOTStaticSanitizerConfig)

roottest/cmake/modules/RoottestMacros.cmake

@@ -53,11 +53,11 @@ endif()
 ROOTTEST_GENERATE_EXECUTABLE(
   read_rntuple
   read_rntuple.cxx
-  LIBRARIES ${ROOT_LIBRARIES} gtest gtest_main gmock gmock_main ${RNTUPLESTLTESTLIB} ROOTNTuple
+  LIBRARIES ${ROOT_LIBRARIES} GTest::gtest GTest::gtest_main GTest::gmock GTest::gmock_main ${RNTUPLESTLTESTLIB} ROOTNTuple
   FIXTURES_REQUIRED makeproject_rntuple_called
   FIXTURES_SETUP read_rntuple_executable
 )
-target_include_directories(read_rntuple PRIVATE ${CMAKE_CURRENT_BINARY_DIR} ${GTEST_INCLUDE_DIR})
+target_include_directories(read_rntuple PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_directories(read_rntuple PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/librntuplestltest)
 
 # Need to also explicitly set the LD_LIBRARY_PATH (at least on MacOS), so that

roottest/root/ntuple/makeproject/rntuple/CMakeLists.txt

@@ -49,11 +49,11 @@ endif()
 ROOTTEST_GENERATE_EXECUTABLE(
   read_ttree
   read_ttree.cxx
-  LIBRARIES ${ROOT_LIBRARIES} gtest gtest_main gmock gmock_main ${TTREESTLTESTLIB}
+  LIBRARIES ${ROOT_LIBRARIES} GTest::gtest GTest::gtest_main GTest::gmock GTest::gmock_main ${TTREESTLTESTLIB}
   FIXTURES_REQUIRED makeproject_ttree_called
   FIXTURES_SETUP read_ttree_executable
 )
-target_include_directories(read_ttree PRIVATE ${CMAKE_CURRENT_BINARY_DIR} ${GTEST_INCLUDE_DIR})
+target_include_directories(read_ttree PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 target_link_directories(read_ttree PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/libttreestltest)
 
 # Need to also explicitly set the LD_LIBRARY_PATH (at least on MacOS), so that