-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[tree] major and minor indices to long64, it was forgotten to change from 32bit of old interfaces #14967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Test Results 21 files 21 suites 3d 7h 35m 42s ⏱️ Results for commit 3ef0516. ♻️ This comment has been updated with latest results. |
vepadulano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but we cannot merge this without a test of the use case before/after this patch
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@vepadulano @pcanal I just noticed that all the 31 bit ugly stuff was due to an outdated documentation. It's no longer the case, minor and major have now independent variables both 64-bits. So this simplifies things significantly. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1bcbfc2 to
06dbb4b
Compare
06dbb4b to
738d723
Compare
|
fyi @TomasDado this PR is 'stalled' since I am not able to figure out a way to make the test pass in all platforms at the same time. If this is urgently needed, the change 'just' in the source code could be in principle decoupled from the test in my opinion, since, even if the change is not perfect, it improves things. |
|
Thanks for the ping @ferdymercury. Maybe it helps if I give some information to the best of my knowledge regarding this issue and ATLAS. We definitely have data periods where the eventNumber (msot commonly used for building the index) exceeds 2^32 thus we also store it as a 64 bit integer. However, I have never seen a need to build the index for data events, this this might not be an urgent issues, althought theoretically it is a problem for data. For MC, where the indexing functionality is definitely used, I am not aware of any sample exceeding 2^32 events although I think we are not that far (~1B events I have seen). Thus, I do not think the issue is urgent, but it might become urgent in the near future if we extend our MC samples. |
… old legacy interface Fixes https://its.cern.ch/jira/browse/ROOT-9028 [treeindex] print error when requesting out of bonds combination 31bit restriction was old, now they have separate 64-bit registers better document old2new
[test] disable tests reaching the limits of ulong64_t since the implicit conversion to long double later leads to platform-dependent test failures
|
@pcanal I would suggest merging this PR 'as is'. The cross-platform compatibility limits of these functions have now been clearly documented, and the tests were simplified to the least common factor. This improves the current situation, instead of using just a maximum of 32 bits, now we can use up to 52 bits, and the documentation informs you about that. |
Co-authored-by: Philippe Canal <[email protected]>
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-9028
Checklist: