ensure C++14 standard for MacOS compatibility #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Jun 9, 2025
Signed-off-by: artcore-c <[email protected]>
Member
|
What error is resolved? Just based on your comment about 14 vs 17, it does feel like something that the packages themselves should be setting (also it doesn't seem specific to macOS to me). I'm just surprised that this isn't already required and that it's not c++17 that is required (we definitely use c++17 only features in rclcpp for example). |
Member
|
Sorry, I guess this isn't part of ament_cmake_ros's core functionally, so it's not setting the cpp standard for other packages. It would still be nice to see the error that is being fixed by this. |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Contributor
|
@artcore-c do you mind to review @wjwwood comments ? |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Contributor
|
Changes are already in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch injects a standards-compliant snippet into
CMakeLists.txt(with appropriate platform guards) to explicitly set the C++14 standard.
Fixes
Resolves a build error encountered when using
colconon macOS,due to default compiler settings lacking explicit C++ standard specification.