✅🚧 Omit 15 SSL connection tests for JRuby

Author: nevans

test/net/imap/test_imap.rb

@@ -13,6 +13,7 @@ class IMAPTest < Net::IMAP::TestCase
 
   if defined?(OpenSSL::SSL::SSLError)
     def test_imaps_unknown_ca
+      omit_if_jruby "SSL tests don't work yet"
       assert_raise(OpenSSL::SSL::SSLError) do
         imaps_test do |port|
           begin
@@ -27,6 +28,7 @@ def test_imaps_unknown_ca
     end
 
     def test_imaps_with_ca_file
+      omit_if_jruby "SSL tests don't work yet"
       # Assert verified *after* the imaps_test and assert_nothing_raised blocks.
       # Otherwise, failures can't logout and need to wait for the timeout.
       verified, imap = :unknown, nil
@@ -54,6 +56,7 @@ def test_imaps_with_ca_file
     end
 
     def test_imaps_verify_none
+      omit_if_jruby "SSL tests don't work yet"
       # Assert verified *after* the imaps_test and assert_nothing_raised blocks.
       # Otherwise, failures can't logout and need to wait for the timeout.
       verified, imap = :unknown, nil
@@ -81,6 +84,7 @@ def test_imaps_verify_none
     end
 
     def test_imaps_post_connection_check
+      omit_if_jruby "SSL tests don't work yet"
       assert_raise(OpenSSL::SSL::SSLError) do
         imaps_test do |port|
           # server_addr is different from the hostname in the certificate,
@@ -95,6 +99,7 @@ def test_imaps_post_connection_check
 
   if defined?(OpenSSL::SSL)
     def test_starttls_unknown_ca
+      omit_if_jruby "SSL tests don't work yet"
       omit "This test is not working with Windows" if RUBY_PLATFORM =~ /mswin|mingw/
 
       imap = nil
@@ -115,6 +120,7 @@ def test_starttls_unknown_ca
     end
 
     def test_starttls
+      omit_if_jruby "SSL tests don't work yet"
       initial_verified, initial_ctx, initial_params = :unknown, :unknown, :unknown
       imap = nil
       starttls_test do |port|
@@ -139,6 +145,7 @@ def test_starttls
     end
 
     def test_starttls_stripping
+      omit_if_jruby "SSL tests don't work yet"
       imap = nil
       starttls_stripping_test do |port|
         imap = Net::IMAP.new("localhost", :port => port)
@@ -497,6 +504,7 @@ def test_connection_closed_during_idle
   end
 
   def test_connection_closed_without_greeting
+    omit_if_jruby "???"
     server = create_tcp_server
     port = server.addr[1]
     h = {

test/net/imap/test_imap_capabilities.rb

@@ -124,6 +124,7 @@ class IMAPCapabilitiesTest < Net::IMAP::TestCase
 
   if defined?(OpenSSL::SSL::SSLError)
     test "#capabilities caches greeting capabilities (implicit TLS)" do
+      omit_if_jruby
       with_fake_server(preauth: false, implicit_tls: true) do |server, imap|
         assert imap.capabilities_cached?
         assert_equal %w[IMAP4REV1 AUTH=PLAIN], imap.capabilities
@@ -136,6 +137,7 @@ class IMAPCapabilitiesTest < Net::IMAP::TestCase
 
     test "#capabilities cache is cleared after #starttls" do
       with_fake_server(preauth: false, cleartext_auth: false) do |server, imap|
+        omit_if_jruby
         assert imap.capabilities_cached?
         assert imap.capable? :IMAP4rev1
         refute imap.auth_capable? "plain"
@@ -189,6 +191,7 @@ class IMAPCapabilitiesTest < Net::IMAP::TestCase
 
   # TODO: should we warn about this?
   test "#capabilities cache IGNORES tagged OK response to STARTTLS" do
+    omit_if_jruby
     with_fake_server(preauth: false) do |server, imap|
       server.on "STARTTLS" do |cmd|
         cmd.done_ok code: "[CAPABILITY IMAP4rev1 AUTH=PLAIN fnord]"

test/net/imap/test_imap_deprecated_client_options.rb

@@ -42,6 +42,7 @@ class InitializeTests < IMAPDeprecatedClientOptionsTest
     end
 
     test "Convert deprecated usessl (= true) and certs, with warning" do
+      omit_if_jruby "SSL tests don't work yet"
       run_fake_server_in_thread(implicit_tls: true) do |server|
         certs = server.config.tls[:ca_file]
         assert_deprecated_warning(/Call Net::IMAP\.new with keyword/i) do
@@ -58,6 +59,7 @@ class InitializeTests < IMAPDeprecatedClientOptionsTest
     end
 
     test "Convert deprecated usessl (= true) and verify (= false), with warning" do
+      omit_if_jruby "SSL tests don't work yet"
       run_fake_server_in_thread(implicit_tls: true) do |server|
         assert_deprecated_warning(/Call Net::IMAP\.new with keyword/i) do
           with_client("localhost", server.port, true, nil, false) do |client|
@@ -89,6 +91,7 @@ class InitializeTests < IMAPDeprecatedClientOptionsTest
 
   class StartTLSTests < IMAPDeprecatedClientOptionsTest
     test "Convert obsolete options hash to keywords" do
+      omit_if_jruby "SSL tests don't work yet"
       with_fake_server(preauth: false) do |server, imap|
         imap.starttls(ca_file: server.config.tls[:ca_file], min_version: :TLS1_2)
         assert_equal(
@@ -101,6 +104,7 @@ class StartTLSTests < IMAPDeprecatedClientOptionsTest
     end
 
     test "Convert deprecated certs, verify with warning" do
+      omit_if_jruby "SSL tests don't work yet"
       with_fake_server(preauth: false) do |server, imap|
         assert_deprecated_warning(/Call Net::IMAP#starttls with keyword/i) do
           imap.starttls(server.config.tls[:ca_file], false)